Re: A doubt about the NodePublishVolume of CSI spec

42 views
Skip to first unread message

Saad Ali

unread,
Jan 12, 2021, 11:13:12 PM1/12/21
to thonic, container-storage-interface-community, jie
+container-storage-interface-community to see if others have ideas.

On Tue, Jan 12, 2021 at 7:53 PM thonic <tho...@foxmail.com> wrote:
Hi!
  I'm a CSI plugin developer of a storage vendor. I had questions about NodePublishVolume recently, wish to get some opinions or guidances from you. Thanks.
  The spec said that the CO SHALL ensure uniqueness of target_path per volume, in the other hand the spec indicated the NodePublishVolume MAY be called by the CO multiple times on the same node for the same volume with possibly DIFFERENT target_path and/or other arguments if the volume has MULTI_NODE capability. So I wonder:

  If Non MULTI_NODE, should I check whether T1==T2? or T1==T2 should be guaranteed by CO? The FAILED_PRECONDITION actually exists in the grpc's status codes, so I don't know if T1==T2 would happen. What's more, checking target_paths seems to require a stateful plugin while we PREFER Deployment to StatefulSet with kubernetes. Are there any other ways to verify these infos gracefully? (maybe save these infos in staging_target_path?)

My 2 cents - CO will most likely not issue additional NodePublishVolume if Non MULTI_NODE for the same volume with a different path. But if the CO has a bug, loses state, etc. it could happen.
So such a check is not critical, but nice to have, so it's up to you on how robust you want to make your plugin to unexpected input.



Respectfully

apurv barve

unread,
Jan 15, 2021, 1:26:34 PM1/15/21
to Saad Ali, thonic, container-storage-interface-community, jie
Yes as stated by Saad, CO may call the API in exceptional scenario multiple times for the same target path, and it is expected that the call must be idem potent. 

--
You received this message because you are subscribed to the Google Groups "container-storage-interface-community" group.
To unsubscribe from this group and stop receiving emails from it, send an email to container-storage-interf...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/container-storage-interface-community/CABBBJP0R9mD4Exv5--GtxincTZQKQy5q181sAd836XKrogRzgA%40mail.gmail.com.
Reply all
Reply to author
Forward
0 new messages