[DISCUSS] Release ConnId 1.4.0.0 (and more)

25 views
Skip to first unread message

Francesco Chicchiriccò

unread,
Jul 2, 2013, 9:04:48 AM7/2/13
to conni...@googlegroups.com
Hi all,
following our recent discussion [1], we have completed the adaptation of
OpenICF sources into the new 1_4_X_Y branch [2].

You can read from BASE-9 [3] (and subtasks) the problems we have faced
and the way how we have solved.

If you don't have issues with the way how the import + adaptation was
done, I would propose to:

1. rename current 'master' branch to '1_3_X'
2. rename current '1_4_X_Y' branch to 'master'
3. release ConnId 1.4.0.0

At this point I think we can finally start discussing about ConnId /
OpenICF 2.0.0

In the meanwhile we will also start migrating all of our connectors to
ConnId 1.4.0.0.

WDYT?

Regards.

[1] https://groups.google.com/d/msg/connid-dev/mKBhLZaKR1Q/JYBDnFDppjUJ
[2] https://github.com/Tirasa/ConnId/tree/1_4_X_Y
[3] https://connid.atlassian.net/browse/BASE-9

--
Francesco Chicchiricc�

ASF Member, Apache Syncope PMC chair, Apache Cocoon PMC Member
http://people.apache.org/~ilgrosso/

Gael Allioux

unread,
Jul 2, 2013, 9:26:34 AM7/2/13
to conni...@googlegroups.com
Hi Francesco,

there are a few enhancements we need to bring into 1.4.x before release.
I'm gonna start another email thread for that.

cheers
Gael

Francesco Chicchiriccò

unread,
Jul 3, 2013, 2:59:00 AM7/3/13
to conni...@googlegroups.com
On 02/07/2013 15:26, Gael Allioux wrote:
> Hi Francesco,
>
> there are a few enhancements we need to bring into 1.4.x before release.
> I'm gonna start another email thread for that.

Fine, let's move to

https://groups.google.com/d/msg/connid-dev/Eoij0JUf3rM/DHWTONjXiVoJ

Regards.

> On 07/02/2013 03:04 PM, Francesco Chicchiriccň wrote:
>> Hi all,
>> following our recent discussion [1], we have completed the adaptation
>> of OpenICF sources into the new 1_4_X_Y branch [2].
>>
>> You can read from BASE-9 [3] (and subtasks) the problems we have
>> faced and the way how we have solved.
>>
>> If you don't have issues with the way how the import + adaptation was
>> done, I would propose to:
>>
>> 1. rename current 'master' branch to '1_3_X'
>> 2. rename current '1_4_X_Y' branch to 'master'
>> 3. release ConnId 1.4.0.0
>>
>> At this point I think we can finally start discussing about ConnId /
>> OpenICF 2.0.0
>>
>> In the meanwhile we will also start migrating all of our connectors
>> to ConnId 1.4.0.0.
>>
>> WDYT?
>>
>> Regards.
>>
>> [1] https://groups.google.com/d/msg/connid-dev/mKBhLZaKR1Q/JYBDnFDppjUJ
>> [2] https://github.com/Tirasa/ConnId/tree/1_4_X_Y
>> [3] https://connid.atlassian.net/browse/BASE-9

--
Francesco Chicchiriccò

László Hordós

unread,
Jul 10, 2013, 3:43:17 AM7/10/13
to conni...@googlegroups.com
Hi, 

Finally I had the time to review the 1_4_X_Y branch. I checked the changes back to https://github.com/Tirasa/ConnId/commit/bea250171e1a24bd60f2d6d3c3bfff7087406230 


#1

As you can see in the javadoc, when @Override was originally introduced, such use was not allowed on Interface and javac 1.5 rejects this. Sun change this in 1.6 and Javac 1.6 allows this.The interesting thing is, if you use Javac 1.6 with "-source 1.5" and/or "-target 1.5". In all the possible combinations, the above code compiles.  The semantics of @Override is defined in the library, not in the Java language spec.

IDEs do seem to tie this with the language level. Eclipse and IntelliJ, when set to language level 1.5, it will flag the above code as an error. I didn't verified it with Netbeans and I assume it does not cause any problem because your target is 1.6 and as I mentioned in my other mail I'd like to keep the 1.5 target level to allow install it on old IBM Java 5 systems.

#2

I don't list here the pom.xml files because I think those will be different between ConnId and OpenICF.

There are files which were in the repository but they didn't have the proper header and now fully licences to ConnId which I think is incorrect. We should add the original Sun header.
  • GroovyConfigReader
  • connectors.dtd
  • JDKLoggerTests
  • Messages.properties
  • GroovyConfigReader
  • connectors-framework.properties
  • logging.properties


connectorserver.properties
-# Copyright 2008-2009 Sun Microsystems, Inc. All rights reserved.
+# Copyright 2013 ConnId. All rights reserved.


overwiev.html
-  DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS HEADER.
 
-  Copyright 2008-2009 Sun Microsystems, Inc. All rights reserved.
+    ====================
+    DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS HEADER.
 
-  The contents of this file are subject to the terms of the Common Development
-  and Distribution License("CDDL") (the "License").  You may not use this file
-  except in compliance with the License.
+    Copyright 2013 ConnId. All rights reserved.

package.html
-  DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS HEADER.
 
-  Copyright 2008-2009 Sun Microsystems, Inc. All rights reserved.
+    ====================
+    DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS HEADER.
 
-  The contents of this file are subject to the terms of the Common Development
-  and Distribution License("CDDL") (the "License").  You may not use this file
-  except in compliance with the License.
+    Copyright 2013 ConnId. All rights reserved.

zip.xml
- DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS HEADER.
 
- Copyright (c) 2011-2013 ForgeRock AS. All rights reserved.
+    ====================
+    DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS HEADER.
 
- The contents of this file are subject to the terms
- of the Common Development and Distribution License
- (the License). You may not use this file except in
- compliance with the License.
+    Copyright 2013 ConnId. All rights reserved.

SLF4JLog
- * Copyright (c) 2011-2013 ForgeRock AS. All Rights Reserved
+ * Copyright (c) 2012 ForgeRock Inc. All rights reserved




--
You received this message because you are subscribed to the Google Groups "connid-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email to connid-dev+...@googlegroups.com.
Visit this group at http://groups.google.com/group/connid-dev.
For more options, visit https://groups.google.com/groups/opt_out.



Francesco Chicchiriccò

unread,
Jul 10, 2013, 4:32:21 AM7/10/13
to conni...@googlegroups.com
On 10/07/2013 09:43, László Hordós wrote:
Hi, 

Finally I had the time to review the 1_4_X_Y branch. I checked the changes back to https://github.com/Tirasa/ConnId/commit/bea250171e1a24bd60f2d6d3c3bfff7087406230 


#1

As you can see in the javadoc, when @Override was originally introduced, such use was not allowed on Interface and javac 1.5 rejects this. Sun change this in 1.6 and Javac 1.6 allows this.The interesting thing is, if you use Javac 1.6 with "-source 1.5" and/or "-target 1.5". In all the possible combinations, the above code compiles.  The semantics of @Override is defined in the library, not in the Java language spec.

IDEs do seem to tie this with the language level. Eclipse and IntelliJ, when set to language level 1.5, it will flag the above code as an error. I didn't verified it with Netbeans and I assume it does not cause any problem because your target is 1.6 and as I mentioned in my other mail I'd like to keep the 1.5 target level to allow install it on old IBM Java 5 systems.

ConnId target is 1.6 since the beginning, here's why the @Override is ubiquitous.
Correct me if I am wrong, but isn't enough for you to set "-source 1.6" / "-target 1.5" in OpenICF pom.xml to be able to build somewhere else and anyway run the code on "old IBM Java 5 systems"?
I have just committed () the fix for these copyright issues above.

Regards.
Reply all
Reply to author
Forward
0 new messages