New pull request!

7 views
Skip to first unread message

Tim Wright

unread,
Oct 28, 2016, 4:07:54 AM10/28/16
to concordion-dev

Hi all,

I've been chatting with Nigel the past week or so about this one. It doesn't change any functionality, but cleans up some internals and fixes some tricky example based bugs. It's an API breaking change.

We're basically changing the concordion process from:
1. parse
2. execute (including tree modification for table execute commands and examples)

to: 
1. parse
2. modify parsed tree
3. execute

It makes things like table execution and examples much much cleaner. In theory we can move the execute on a list logic to use this new structure, but I haven't done that :)


Tim

Nigel Charman

unread,
Oct 29, 2016, 4:21:52 PM10/29/16
to concord...@googlegroups.com
Thanks Tim, I've pulled the changes in. They do clean up a lot of code.

Would you raise an issue for moving the execute on a list so we don't forget.

Nigel.
--
You received this message because you are subscribed to the Google Groups "concordion-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email to concordion-de...@googlegroups.com.
To post to this group, send email to concord...@googlegroups.com.
Visit this group at https://groups.google.com/group/concordion-dev.
To view this discussion on the web, visit https://groups.google.com/d/msgid/concordion-dev/CAJifTyqTWTSJnAC127At39BVgP05nDOXMUFezPQgEo5PGKksMg%40mail.gmail.com.
For more options, visit https://groups.google.com/d/optout.


Reply all
Reply to author
Forward
0 new messages