Missing suspendables for Jersey

[victo...@gmail.com]

Hi,

While playing with Jersey and its filters, I found some missing suspendables declarations in the comsat package.

Basically, it is needed when one extends javax.ws.rs.container.ContainerRequestFilter.filter(ContainerRequestContext) with some fiber-enabled code.

for suspendable-supers:
javax.ws.rs.container.ContainerRequestFilter.filter(ContainerRequestContext)
org.glassfish.jersey.process.internal.Stage.apply(DATA)

for suspendables:
org.glassfish.jersey.server.ContainerFilteringStage.apply(RequestProcessingContext)
org.glassfish.jersey.process.internal.Stages.process(DATA, Stage<DATA>, Ref<T>)

And that should be all I think!

Hope this helps,

Victor

[circlespainter]

Hi, could you also open a PR about that (with a unit test if you can)?

Thanks,

-- Fabio

[victo...@gmail.com]

Hi,

I will be unavailable for a month, but I can do it without any problem in September if you you can wait :)

Thanks!

[victo...@gmail.com]

Hi again, I'm really not familiar with Gradle and your build also.

A few questions:
 - I don't know why but when I import comsat into Eclipse, the dependency for quasar-actors is found, but not the one for quasar itself… any idea what could cause that? It's not even a SNAPSHOT dependency…
 - Is it normal that when I run "gradle test" in "comsat-jersey-server" I get the following warnings:
[ant:scanSuspendables] Found parent of suspendable method: co/paralleluniverse/fibers/servlet/FiberHttpServlet.doTrace(Ljavax/servlet/http/HttpServletRequest;Ljavax/servlet/http/HttpServletResponse;)V in javax/servlet/http/HttpServlet NOT IN PROJECT
[ant:scanSuspendables] Found parent of suspendable method: co/paralleluniverse/fibers/servlet/FiberHttpServlet.service(Ljavax/servlet/http/HttpServletRequest;Ljavax/servlet/http/HttpServletResponse;)V in javax/servlet/http/HttpServlet NOT IN PROJECT
[ant:scanSuspendables] Found parent of suspendable method: co/paralleluniverse/fibers/servlet/FiberHttpServlet.doPut(Ljavax/servlet/http/HttpServletRequest;Ljavax/servlet/http/HttpServletResponse;)V in javax/servlet/http/HttpServlet NOT IN PROJECT
… and so on

Thanks!

Le jeudi 28 juillet 2016 21:00:43 UTC+2, circlespainter a écrit :

[victo...@gmail.com]

It seems the quasar-core dependency missing in eclipse is caused by this "configurations" thing with a specific one called quasar… I added the dependency as compile for my tests :)

How do I see the details of the errors when the test from comsat-jersey-server fails? I just can't see anything else from the very generic error of the test: org.apache.http.client.HttpResponseException: Internal Server Error

There is nothing about the server side :/

[victo...@gmail.com]

Here it is with tests!

https://github.com/puniverse/comsat/pull/71

Le jeudi 28 juillet 2016 21:00:43 UTC+2, circlespainter a écrit :

[circlespainter]

Great, thanks! I'll have a look soon.

-- Fabio