Re: Folly in Godbolt?

[Matt Godbolt]

Hi Michael, (CC the development mailing list)

Thanks so much for taking the time to want to add a library to CE, and to have spent time looking at how to do so.

We try to avoid shell script things (though we can do it). We have to carefully script up the compiler dependencies for library that have a built component (as we need to build for all the various compilers, etc). As you can imagine, it's a pain. Our library building system isn't ideal...

Most libraries are header-only, (or we support it only header only), for exactly this reason.

Is there any chance you can join us on our Discord? We can chat more interactively there, and/or the person who helps with library build (Partouf) might be able to chime in with info!

Cheers, Matt :)

On Mon, Nov 22, 2021 at 4:27 PM Michael Voznesensky <v...@fb.com> wrote:

Hello!

I am a huge​ fan of The Compiler Explorer. I was hoping to add Follly (https://github.com/facebook/folly) to it. However, I noticed that under compiler-explorer/infra/bin/yaml/libraries.yaml, there are no examples of .sh scripts being invoked or used anywhere. Folly has a general purpose ./build.sh step that wraps pulling in dependencies and calling all the various make steps under the hood. 

I saw that the docs instruct to reach out for any uncommon integrations and use cases. As there is no prior art of using a shell script (that I could find) to get a lib into the CE, I figured this is a just such a case.

Thank you,
Michael Voznesensky
v...@fb.com
voznes...@gmail.com (If you prefer to interact with individuals in open source instead of corporate handles)

--

Matt

(he/him)

[Michael Voznesensky]

Sounds great, 

There are things we can do on our end to make it work with CMake only commands, let me play with that in a local environment and see how far I get. I was hoping for a shortcut ;) but principles are principles, and I totally get not wanting to take on the unbounded scope of things exposing shell scripts could bring on. 

My apologies, I’m new to the community, what is the discord url / name?

Thank you,

Michael 

[Matt Godbolt]

Hi Michael,

No worries at all! The shell script thing is not an issue as such - we just don't "build" and install in one step in most of our installers. We separate building from installation (partly as we install daily, but only build on changes, partly historically). The unbounded shell script thing is true: this is another reason our builds run docker (so we bound the damage they can do), but our installs are usually "copy the bits that were built" and so safer, for some definition of safer.

The Discord is https://discord.gg/fUwWKGkR - and welcome to community! Sorry I meant to link the Discord but forgot!

Thanks, Matt

--

Matt

(he/him)