Google Groups no longer supports new Usenet posts or subscriptions. Historical content remains viewable.
Dismiss

Removing items from a list

41 views
Skip to first unread message

Thomas Philips

unread,
Feb 10, 2012, 3:04:34 PM2/10/12
to
In the past, when deleting items from a list, I looped through the
list in reverse to avoid accidentally deleting items I wanted to keep.
I tried something different today, and, to my surprise, was able to
delete items correctly, regardless of the direction in which I looped,
in both Python 3.2.2. and 2..1 - does the remove() function somehow
allow the iteration to continue correctly even when items are removed
from the midde of the list?

>>> x = list(range(10))
>>> x
[0, 1, 2, 3, 4, 5, 6, 7, 8, 9]
>>> for i in x:
if i % 2 == 0:
x.remove(i)

>>> x
[1, 3, 5, 7, 9]
>>> for i in reversed(x):
if i % 2 == 0:
x.remove(i)

>>> x
[1, 3, 5, 7, 9]
>>> x = list(range(10))
>>> for i in reversed(x):
if i % 2 == 0:
x.remove(i)


>>> x
[1, 3, 5, 7, 9]

Sincerely

Thomas Philips

Ian Kelly

unread,
Feb 10, 2012, 3:22:47 PM2/10/12
to Thomas Philips, pytho...@python.org
On Fri, Feb 10, 2012 at 1:04 PM, Thomas Philips <tkp...@gmail.com> wrote:
> In the past, when deleting items from a list, I looped through the
> list in reverse to avoid accidentally deleting items I wanted to keep.
> I tried something different today, and, to my surprise, was able to
> delete items correctly, regardless of the direction in which I looped,
> in both Python 3.2.2. and 2..1 -  does the remove() function somehow
> allow the iteration to continue correctly even when items are removed
> from the midde of the list?

No. Your test works because you never attempt to remove two adjacent
items, so the skipping of items doesn't end up mattering. Try the
same thing, but print out the values as you iterate over them:


>>> x = list(range(10))
>>> x
[0, 1, 2, 3, 4, 5, 6, 7, 8, 9]
>>> for i in x:
... print(i)
... if i % 2 == 0:
... x.remove(i)
...
0
2
4
6
8
>>> x
[1, 3, 5, 7, 9]


Had you attempted to remove any of the odd numbers as well, it would
have failed.

Cheers,
Ian

MRAB

unread,
Feb 10, 2012, 3:26:26 PM2/10/12
to pytho...@python.org
The answer is no. For example:

>>> for i in x:
print("i is", i)
if i % 2 == 0:
x.remove(i)


i is 0
i is 1
i is 2
i is 4
>>> x
[0, 1, 3, 5]

Thomas Philips

unread,
Feb 10, 2012, 3:48:49 PM2/10/12
to
Thanks for the insight. I saw the behavious as soon as I extended x
with a bunch of 0's

>>> x = list(range(10))
>>> x.extend([0]*10)
>>> x
[0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0]
>>> for i in reversed(x):
if i % 2 == 0:
x.remove(i)

>>> x
[1, 3, 5, 7, 9]

>>> x = list(range(10))
>>> x.extend([0]*10)
>>> x
[0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0]
>>> for i in x:
if i % 2 == 0:
x.remove(i)


>>> x
[1, 3, 5, 7, 9, 0, 0, 0, 0, 0]

Chris Angelico

unread,
Feb 10, 2012, 4:58:55 PM2/10/12
to pytho...@python.org
On Sat, Feb 11, 2012 at 7:04 AM, Thomas Philips <tkp...@gmail.com> wrote:
> [0, 1, 2, 3, 4, 5, 6, 7, 8, 9]
>>>> for i in x:
>        if i % 2 == 0:
>                x.remove(i)

Just a quickie, is there a reason you can't use a list comprehension?

x = [i for i in x if i % 2]

ChrisA

Thomas Philips

unread,
Feb 13, 2012, 8:55:41 AM2/13/12
to
I could indeed have addressed this problem with a list comprehension.
It escaped me at the time because the larger problem I was trying to
solve included removing data from a dictionary:

months =
sorted(list(dataDict.keys())) #Sort
months in ascending order

for mth in
reversed(months): #Remove
months with inadequate data
if len(dataDict[mth]) < minItems:
months.remove(mth)
del dataDict[mth]

There's more than one way to solve this problem, and, with the benefit
of hindsight, my solution was sloppy, but thanks to the help I
received, I was able to get my code working correctly. Cleaning up is
the next phase!

Thanks, all.

0 new messages