PVS-Studio: Critical errors in CryEngine V code

[Andrey Karpov]

In May 2016, German game-development company Crytek made the, decision to upload the source code of their game engine, 'CryEngine V' to GitHub. The project is in active development, which leads to a large number of errors in the code. We have already checked the project with PVS-Studio for Windows, and now we can also analyze it using PVS-Studio for Linux. There was enough material for an article with the description of only crucial errors.

Article: https://www.viva64.com/en/b/0495/

[Rick C. Hodgin]

"Critical errors"

#1 It's code for a video game engine, not a life support system.

#2 Does the game run? A critical error would prevent it from running.
A bug would prevent it from running corre in certain cases.

#3 How much money do you expect to make off this post on comp.lang.c++ ?
And how much knowledge do you hope to impart to people, to increase their
developer skills?

Thank you,
Rick C. Hodgin

[Chris M. Thomasson]

On 4/4/2017 7:07 AM, Rick C. Hodgin wrote:
> "Critical errors"
>
> #1 It's code for a video game engine, not a life support system.
>
> #2 Does the game run? A critical error would prevent it from running.
> A bug would prevent it from running corre in certain cases.

Heck, what about this approximation for sqrt in a game:

http://forums.parallax.com/discussion/147522/dog-leg-hypotenuse-approximation

Better than using a real sqrt function! ;^)

[Gareth Owen]

Andrey Karpov <karpo...@gmail.com> writes:

> There was enough material for an article with the description of only
> crucial errors.
>
> Article: https://www.viva64.com/en/b/0495/

You have a weird idea of what constitutes a "crucial error". I'd hate
to see the list of trivial ones.

[asetof...@gmail.com]

Float Point numbers operator compare has to use epsilon...
For example
double x;

....
No if(x==1.0) etc
Yes if(absfordouble(x-1.0)<0.0001) etc

[Bonita Montero]

> Heck, what about this approximation for sqrt in a game:

SSE includes RSQRTSS/PS for the usual 3D-graphis purpose.

--
http://facebook.com/bonita.montero/