Minor problem with Makefile.shlib

[Thomas Hallgren]

I have a minor issue with Makefile.shlib. Compiling with win32 it spits
out these warnings (the same is true for Cygwin)

Makefile.shlib:327: warning: overriding commands for target `libpljava.a'
Makefile.shlib:262: warning: ignoring old commands for target
`libpljava.a'

As it turns out, the rule to make the lib$(NAME).a actually has commands
defined in multiple places when Cygwin or win32 is used. In global scope
we find the following at line 260:

lib$(NAME).a: $(OBJS)
ifdef MK_NO_LORDER
$(LINK.static) $@ $^
else
$(LINK.static) $@ `$(LORDER) $^ | tsort`
endif
$(RANLIB) $@

Then, further down and win32 specific on line 325:

$(shlib) lib$(NAME).a: $(OBJS)
ifndef DLL_DEFFILE
$(DLLTOOL) --export-all $(DLLTOOL_DEFFLAGS) --output-def $(NAME).def
$(OBJS)
$(DLLWRAP) $(LDFLAGS_SL) -o $(shlib) --dllname $(shlib)
$(DLLWRAP_FLAGS) --def $(NAME).def $(OBJS) $(SHLIB_LINK)
$(DLLTOOL) --dllname $(shlib) $(DLLTOOL_LIBFLAGS) --def $(NAME).def
--output-lib lib$(NAME).a
else
$(DLLWRAP) $(LDFLAGS_SL) -o $(shlib) --dllname $(shlib)
$(DLLWRAP_FLAGS) --def $(DLL_DEFFILE) $(OBJS) $(SHLIB_LINK)
$(DLLTOOL) --dllname $(shlib) $(DLLTOOL_LIBFLAGS) --def $(DLL_DEFFILE)
--output-lib lib$(NAME).a
endif

endif # PORTNAME == win32

As I said, it's is no big issue since it just results in two warnings.

Regards,
Thomas Hallgren

---------------------------(end of broadcast)---------------------------
TIP 5: Have you checked our extensive FAQ?

http://www.postgresql.org/docs/faqs/FAQ.html

[Andrew Dunstan]

I submitted a patch to fix this on October 21st, but it has not been
applied (in common with several other cleanup patches I sent in about a
week ago).

cheers

andrew

Thomas Hallgren wrote:

---------------------------(end of broadcast)---------------------------
TIP 2: you can get off all lists at once with the unregister command
(send "unregister YourEmailAddressHere" to majo...@postgresql.org)

[Tom Lane]

Andrew Dunstan <and...@dunslane.net> writes:
> I submitted a patch to fix this on October 21st, but it has not been
> applied (in common with several other cleanup patches I sent in about a
> week ago).

Bruce got horribly backlogged recently and didn't get any patches in to
speak of. Since he's in California this week, I'm going to try to pick
up the slack so we can still push out beta5 in the next day or so.

However, I don't seem to have anything from you on that date in my
inbox; could you send it to me off-list?

regards, tom lane

---------------------------(end of broadcast)---------------------------
TIP 1: subscribe and unsubscribe commands go to majo...@postgresql.org