where is "Add image to Wikipedia"?

[Amir E. Aharoni]

Hi!

First, a little introduction: I've contributed to the content and the software of Wikimedia projects for more than 20 years, especially in the area of localization. I'm one of the administrators of translatewiki. I've made some minor contributions to the Commons app over the years—mostly things like fixing spelling errors in translatable messages.

Recently, I've wanted to learn more about Android development and to try to fix some more substantial bugs in the app. One of the things I'm doing now is auditing all the ~800 translatable messages—completing the documentation ("qq") of existing ones, finding and removing unused ones, etc.

There's one message that I find particularly puzzling: "Add image to Wikipedia" (<string name="add_picture_to_wikipedia_article_title">). Where does it appear? I could find it in the code, but I can't find it in the actual app. It is supposed to be shown when a "Wikipedia icon" is clicked, but where is this Wikipedia icon?

Thanks!

--
Amir Elisha Aharoni · אָמִיר אֱלִישָׁע אַהֲרוֹנִי
http://aharoni.wordpress.com
‪“We're living in pieces,
I want to live in peace.” – T. Moore‬

[Yusuke Matsubara]

Hi Amir,

Thanks for your contribution!

I haven't tested (at least not recently) but I think the feature is
activated only when there is a connected Wikidata entry for the image
you are visiting, and a Wikipedia article missing images. The
Wikipedia icon will be visible then, too.

This is my best guess looking at the code written in ContributionViewHolder.kt.

-Yusuke

> --
> You received this message because you are subscribed to the Google Groups "commons-app-android" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to commons-app-and...@googlegroups.com.
> To view this discussion visit https://groups.google.com/d/msgid/commons-app-android/CACtNa8vcbGnMxX5R%3DYbk1XG_ixSzZd1ppuD72%2B1dkz91tVzrkA%40mail.gmail.com.

[Amir E. Aharoni]

Thank you!

This raises a few questions:

1. In which languages is Wikipedia checked when this is done? What happens if there is a photo in the Italian Wikipedia, but not in the Spanish Wikipedia, for example?

2. Does it have to be an article with no images at all? Why not allow adding more photos to an article that already has some?

--
Amir Elisha Aharoni · אָמִיר אֱלִישָׁע אַהֲרוֹנִי
http://aharoni.wordpress.com
‪“We're living in pieces,
I want to live in peace.” – T. Moore‬

[Kaartic Sivaraam]

Hi Amir,

I wish I could answer your question more specifically but I kind of lack the current knowledge of that feature to do so. That said, I believe the following issue would give you the context you're looking for:

https://github.com/commons-app/apps-android-commons/issues/872

Side note, I've seldom seen the "Add to Wikipedia" icon in the app but I don't often upload images via Nearby (which would associate an Wikidata item to the image) so I'm not the best person to comment on the feature's working. Others who have used the feature may be better placed to comment.

--

Sivaraam