Affected by a mozilla change (probably the for-each change), some colors are wrong.

[dqe...@gmail.com]

Hi!

Something caused some colors to be rendered wrong. My guess is: https://bugzilla.mozilla.org/show_bug.cgi?id=1293305
But it's definitely something that landed between the 2016-11-19 and 2016-11-22 nightly builds.

[Michael]

Hi!,

Am Donnerstag, 24. November 2016 18:11:23 UTC+1 schrieb d*@gmail.com:

Something caused some colors to be rendered wrong. My guess is: https://bugzilla.mozilla.org/show_bug.cgi?id=1293305
But it's definitely something that landed between the 2016-11-19 and 2016-11-22 nightly builds.

You're referring to this?:
https://developer.mozilla.org/de/docs/Web/JavaScript/Reference/Errors/For-each-in_loops_are_deprecated

I searched the add-on code for deprecated "for each" loops but found nothing. So I understand that this is not the problem.

Are the colors rendered wrong in the existing color-edits or only during/after new color edits?

Wrong colors in already existing edits indicate "problems" or "behaviour changes" in the interpretation of CSS rules by mozilla. The add-on just creates static user-defined css. When Mozilla "mis-interpretes" such edits it might be either an error in their CSS-engine (it is a nightly build we're speaking of after all) or there was some CSS error/inconsitency for ages in the engine which is now "corrected".

[dqe...@gmail.com]

You're referring to this?:
https://developer.mozilla.org/de/docs/Web/JavaScript/Reference/Errors/For-each-in_loops_are_deprecated

I searched the add-on code for deprecated "for each" loops but found nothing. So I understand that this is not the problem.

Well, it was just a guess.
 

Are the colors rendered wrong in the existing color-edits or only during/after new color edits?

Wrong colors in already existing edits indicate "problems" or "behaviour changes" in the interpretation of CSS rules by mozilla. The add-on just creates static user-defined css. When Mozilla "mis-interpretes" such edits it might be either an error in their CSS-engine (it is a nightly build we're speaking of after all) or there was some CSS error/inconsitency for ages in the engine which is now "corrected".

I noticed that checkboxes started to render differently on mozillazine, without me changing anything. Here's the old vs new appearance.