i18n/l10n: documentation and gui
Martin Ereth
Hash: SHA1
Hello Jonathon and readers!
I tried out 0.4.4 because Christian Zwahlen wrote me that the help is not yet translated.
So the first thing is: What about the translation of the documentation? Can we already
start to translate it, or is it in a too early stage?
If yes, how could the translation be done? I don't think we have to edit the
XML-files, do we?
The other thing is: The current app misses the ability of the translation of the
Name:-Tag of the GIMP-Palette files "gpl". (The dropdown-menu at the bottom of the
mainwindow)
I found "src/paletteparser/palette.h": Glib::ustring Palette::parse_name(const char*
line). The Name:-Tag is parsed there.
Maybe we (or I or you :-)) can add some lines of code there to get the names translated?
I can try it, if you like. But I don't promise anything ;-)
current intention: [1]
What do you think?
Martin
[1]
My current intention is to write a function which returns the localized name if one
exists. As parameter name it receives the entry of the Name:-tag.
Glib::ustring Palette::get_l10n_name(const char* name)
{
if (name == "Web-safe colors")
return _("Web-safe colors");
else if (name == "GNOME Icon Palette")
...
}
In that way the names of the palettes can be translated in the known process of
localization. But the resulting problem is that it isn't that flexible any more. But
that is IMHO not a real problem because the 4 palette files are delivered together
with agave :-)
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.9 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org
iEYEARECAAYFAkgd4UEACgkQE5UqXaCvB8KbGwCeMqFt6/UUt1lMmDy6uwh2mlXr
cAQAnjbagi4/bsUT3yn70KCrNcu8ADIF
=GZe1
-----END PGP SIGNATURE-----
Martin Ereth
Hash: SHA1
Martin Ereth wrote:
| current intention:
[...]
I have done something about my recent intentions :-)
I've appended a patch.
This is my first patch concerning real source code I contribute to any project. So
please be patient and show me my errors! Change the code as you like and I would like
to request that you tell me about it.
Martin
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.9 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org
iEYEARECAAYFAkgeJtAACgkQE5UqXaCvB8KvUQCgr3pdhYEtSL5IipSoEwOSo9P4
Fe0AoKPBtnKU9I4u/B1i2Rxc0hpKgzTo
=ZQyV
-----END PGP SIGNATURE-----
Jonathon Jongsma
> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA1
>
> Martin Ereth wrote:
> | current intention:
> [...]
>
> I have done something about my recent intentions :-)
> I've appended a patch.
>
> This is my first patch concerning real source code I contribute to any project. So
> please be patient and show me my errors! Change the code as you like and I would like
> to request that you tell me about it.
>
> Martin
Hello Martin,
Well, the 'correct' solution would probably be to write some sort of
support for intltool that would automatically extract the text from the
palette files and add it to the .pot file. But I don't really have the
desire to do that, and your idea seems like it would work just fine with
a lot less work. I haven't tested it yet, but I'll try to apply it and
include it in the next release. Thanks a lot for doing that.
(p.s. from just quickly looking at the patch, one thing I would probably
change is to make the function take a 'const Glib::ustring&' instead.
As a general rule, I like to pass strings by const reference unless
there's a good reason not to. Also, the function could probably be
static since it doesn't access any class data. But those are only minor
things; in general it looks fine.)
--
Jonner