Re: Issue 84 in rietveld: Rietveld lists modified files as deleted.

1 view
Skip to first unread message

riet...@googlecode.com

unread,
Sep 27, 2010, 1:40:07 AM9/27/10
to coderev...@googlegroups.com
Updates:
Labels: -Priority-Medium Priority-High

Comment #2 on issue 84 by techtonik: Rietveld lists modified files as
deleted.
http://code.google.com/p/rietveld/issues/detail?id=84

Is this repeatable with current r575?

riet...@googlecode.com

unread,
Oct 1, 2014, 8:39:51 PM10/1/14
to coderev...@googlegroups.com

Comment #4 on issue 84 by mgi...@chromium.org: Rietveld lists modified
files as deleted.
https://code.google.com/p/rietveld/issues/detail?id=84

Still occurring at current revision on Chromium (October 2014).

See Patch Set 8 on https://codereview.chromium.org/598013003/.

--
You received this message because this project is configured to send all
issue notifications to this address.
You may adjust your notification preferences at:
https://code.google.com/hosting/settings

riet...@googlecode.com

unread,
Oct 1, 2014, 8:47:55 PM10/1/14
to coderev...@googlegroups.com

Comment #5 on issue 84 by mgi...@chromium.org: Rietveld lists modified
Discovered a work-around: if you upload a new patch set which removes all
changes to the file in question, and then another patch set which puts them
back, Rietveld will discover that it is modified, not deleted. (See Patch
Sets 9 and 10 on the above CL.)

In any case, I doubt it would be a problem when submitting, as the raw diff
is still correct.
Reply all
Reply to author
Forward
0 new messages