Issue 372 in rietveld: Usability issue: no mail sent when reviewers added in "Edit issue" form

[riet...@googlecode.com]

Status: Accepted
Owner: gu...@google.com
Labels: Type-Defect Priority-Medium

New issue 372 by gu...@google.com: Usability issue: no mail sent when
reviewers added in "Edit issue" form
http://code.google.com/p/rietveld/issues/detail?id=372

I just spent some time helping a user track an issue where they thought
mail was being dropped. (See the last few comments in issue 346.) After
various tests the user realized that they were editing the issue in order
to add a reviewer and expected that upon submitting that form the reviewer
would receive an email. We could fix this by sending email in this case,
but IIRC we thought about that and decided that we should *not* be sending
mail in that case. So perhaps a better response might be to add a note
somewhere to the form reminding the user that no mail will be sent and to
use Publish+Mail to send email.

[riet...@googlecode.com]

Comment #1 on issue 372 by tech...@gmail.com: Usability issue: no mail

sent when reviewers added in "Edit issue" form
http://code.google.com/p/rietveld/issues/detail?id=372

It is interesting to know why not? In Trac it is not only convenient to
receive such notifications, but also to browse history of such changes.

[riet...@googlecode.com]

Comment #2 on issue 372 by gu...@google.com: Usability issue: no mail sent

when reviewers added in "Edit issue" form
http://code.google.com/p/rietveld/issues/detail?id=372

I would actually be fine with sending email in such cases. We'd need
a "send email" checkbox that is on by default so that a careful developer
can suppress a needless email for a trivial change. FWIW I wasn't going to
implement this myself, be my guest if you feel like it.

We migh change upload.py to also always send email.