Move viewport on arrow key (issue382). (issue 6221068)

[albrec...@googlemail.com]

Reviewers: GvR, techtonik,

Description:
Move viewport on arrow key (issue382).

Please review this at http://codereview.appspot.com/6221068/

Affected files:
M static/script.js


Index: static/script.js
===================================================================
--- a/static/script.js
+++ b/static/script.js
@@ -1737,9 +1737,7 @@
var tr = codeRows[hookIdx];
if (tr) {
this.updateIndicator_(tr);
- if (!M_isElementVisible(this.win, tr)) {
- M_scrollIntoView(this.win, tr, direction);
- }
+ M_scrollIntoView(this.win, tr, direction);
}
}

[tech...@gmail.com]

Any place to play with?

http://codereview.appspot.com/6221068/

[tech...@gmail.com]

I am a bad reviewer, because I dislike this "feature" too. For
PgUp/PgDown should me the cursor too.

http://codereview.appspot.com/6221068/

[tech...@gmail.com]

s/me/move/

http://codereview.appspot.com/6221068/

[gvanr...@gmail.com]

LGTM

http://codereview.appspot.com/6221068/

[albrec...@googlemail.com]

This is now live.

Thanks for the review!

http://codereview.appspot.com/6221068/

[tech...@gmail.com]

Cool stuff. I'd eliminate delay between keypresses for it if I had some
free time.

http://www.duchnik.com/tutorials/2011/08/30/beginner-html5-game-development-part-5-multiple-key-press/

http://codereview.appspot.com/6221068/