Re: Issue 346 in rietveld: Rietveld code review requests and updates don't send email notifications

[riet...@googlecode.com]

Updates:
Summary: Rietveld code review requests and updates don't send email
notifications
Status: Fixed

Comment #1 on issue 346 by gvanros...@gmail.com: Rietveld code review
requests and updates don't send email notifications
http://code.google.com/p/rietveld/issues/detail?id=346

We just made a config change and this should now work again. If it doesn't,
please reopen this issue.

[riet...@googlecode.com]

Comment #2 on issue 346 by tech...@gmail.com: Rietveld code review

requests and updates don't send email notifications
http://code.google.com/p/rietveld/issues/detail?id=346

It seems to be 'Authentication Options' menu that is also displayed when
creating app. But I couldn't find the option. The closes one:

"""Open to all Google Accounts users (default)

If your application uses authentication, anyone with a valid Google Account
may sign in. (This includes all Gmail Accounts, but does *not* include
accounts on any Google Apps domains.)"""

Does that mean that Rietveld is special? And users won't be able to login
into my AppEngine application with their non @gmail Google accounts?

[riet...@googlecode.com]

Comment #3 on issue 346 by gvanros...@gmail.com: Rietveld code review

requests and updates don't send email notifications
http://code.google.com/p/rietveld/issues/detail?id=346

No, it has nothing to do with that option. That option selects the
*authentication* method. Choices are "Google Accounts" (not quite the same
as GMail account but open to anyone in the public); "Google Accounts for
your domain" (for corporate Google Apps users) and OpenID.

If you select Google Accounts (the default), anyone with a non-corporate
Google Account can log in to your app, regardless of whether the email
associated with the account is GMail or a 3rd party email address.

However *this* issue is about email sent from the app. An app can send
email either from any of the app admins or from the currently-logged-in
user. However an additional restriction is that the email address used to
send email must also be either a GMail address or a corporate Google
Account. Rietveld indeed has a special permission to bypass this
additional restruction.

[riet...@googlecode.com]

Comment #4 on issue 346 by gvanros...@gmail.com: Rietveld code review

requests and updates don't send email notifications
http://code.google.com/p/rietveld/issues/detail?id=346

> If you select Google Accounts (the default), anyone with a non-corporate

> Google Account can log in to your app, regardless of whether the email
> associated with the account is GMail or a 3rd party email address.

Actually I think most corporate account users can log in too. For legacy
domains some kind of conversion must have been approved by the domain
admins, but AFAIK most domains have gone through that by now.

[riet...@googlecode.com]

Comment #5 on issue 346 by mfschwa...@google.com: Rietveld code review

requests and updates don't send email notifications
http://code.google.com/p/rietveld/issues/detail?id=346

Just to be clear: I've been using Rietveld for code reviews for 8+ months
between my corp account and other corp accounts as well as other gmail
accounts. Notifications used to work. Nothing in my email address changed,
so it seems like something in the app or its configuration changed and
stopped working wrt notifications recently.

[riet...@googlecode.com]

Comment #6 on issue 346 by gvanros...@gmail.com: Rietveld code review

requests and updates don't send email notifications
http://code.google.com/p/rietveld/issues/detail?id=346

Yeah, and we fixed it this morning. (The temporary breakage was because we
actually migrated to a new app instance, and this special configuration bit
was not set for that instance initially.) So please try it and let me know
(offline) if it is still broken.

[riet...@googlecode.com]

Comment #7 on issue 346 by mfschwa...@google.com: Rietveld code review

requests and updates don't send email notifications
http://code.google.com/p/rietveld/issues/detail?id=346

Oh, right, you said that it was fixed before. Sorry, it's been a busy day.

I'll let you know if it's still not fixed next time I try it. Thanks.

[anatoly techtonik]

On Sat, Nov 19, 2011 at 1:01 AM, <riet...@googlecode.com> wrote:

No, it has nothing to do with that option.  That option selects the *authentication* method.  Choices are "Google Accounts" (not quite the same as GMail account but open to anyone in the public); "Google Accounts for your domain" (for corporate Google Apps users) and OpenID.

Oh. Thanks for clarification. Friday evenings are hard.

[riet...@googlecode.com]

Comment #9 on issue 346 by mfschwa...@google.com: Rietveld code review

requests and updates don't send email notifications
http://code.google.com/p/rietveld/issues/detail?id=346

Hi - FYI Rietveld regularly fails to send email notifications when we use
it for code reviews. We have gotten in the habit of always sending our own
emails to one another when we send a request for a review or when we
perform a review.

This most recently happened today (2/20/2012), and every time I've used
Rietveld in the past few weeks.

[riet...@googlecode.com]

Comment #10 on issue 346 by gvanros...@gmail.com: Rietveld code review

requests and updates don't send email notifications
http://code.google.com/p/rietveld/issues/detail?id=346

Which Rietveld instance are you using? codereview.appspot.com or your own
instance? Which email was used for the sender (i.e. the email of the
logged-in user)? Which issue#? Which recipients? Have you checked for
typos? Have the receivers thoroughly searched their spam folders?

[riet...@googlecode.com]

Comment #11 on issue 346 by mfschwa...@google.com: Rietveld code review

requests and updates don't send email notifications
http://code.google.com/p/rietveld/issues/detail?id=346

codereview.appspot.com

Which email was used for the sender (i.e. the email of the logged-in user)?

marc...@google.com

http://codereview.appspot.com**/5688051/<http://codereview.appspot.com/5688051/>

myself (mfsch...@google.com)

This happens regularly, so it's definitely not a case of typos.

I just looked now, and I have only 2 messages in my spam folder, neither of
which is a Rietveld notification.
This is for a code review request sent by Marc last night.

Mike

[riet...@googlecode.com]

Comment #12 on issue 346 by gvanros...@gmail.com: Rietveld code review

requests and updates don't send email notifications
http://code.google.com/p/rietveld/issues/detail?id=346

Which UI did you use to send the email? The web UI, or some upload.py
command? There are known issues where upload.py often doesn't send mail.

[riet...@googlecode.com]

Comment #13 on issue 346 by mfschwa...@google.com: Rietveld code review

requests and updates don't send email notifications
http://code.google.com/p/rietveld/issues/detail?id=346

The web UI. Specifically, I edit the issue and add my reviewers, then go
publish the issue. When that's done I see the notification my the person to
whom I sent the review does not. (I regularly see the latter myself, being
a reviewer that doesn't get notifications)

[riet...@googlecode.com]

Comment #14 on issue 346 by gvanros...@gmail.com: Rietveld code review

requests and updates don't send email notifications
http://code.google.com/p/rietveld/issues/detail?id=346

Could you try (or ask) sending a test message for that same issue and let
me know if the email arrived or not? I'd like to look through the logs but
it's hard to browse back to day-old logs. I'm also entertaining the
possibility that, since both of you are using your @google.com address,
there's a Google-specific ban on email sent by external mail servers
appearing to come from another @google.com account. (For all intents and
purposes, App Engine is considered external infrastructure.)

[riet...@googlecode.com]

Comment #15 on issue 346 by mfschwa...@google.com: Rietveld code review

requests and updates don't send email notifications
http://code.google.com/p/rietveld/issues/detail?id=346

Hi - when you say "try sending a test message for that same issue" I'm not
sure what you're suggesting. Do you mean to Publish + Mail Draft Comments
from the Rietveld UI? Or did you mean to send email to
re...@codereview-hr.appspotmail.com, with the issue number in the subject
line? Or ... ?

[riet...@googlecode.com]

Comment #16 on issue 346 by gvanros...@gmail.com: Rietveld code review

requests and updates don't send email notifications
http://code.google.com/p/rietveld/issues/detail?id=346

Sorry, I meant use Publish + Mail Draft Comments. I don't know what
timezone you are in, but could you coordinate this via chat so I am online
when you do the test?

[riet...@googlecode.com]

Comment #17 on issue 346 by gvanros...@gmail.com: Rietveld code review

requests and updates don't send email notifications
http://code.google.com/p/rietveld/issues/detail?id=346

(That is, chat to gu...@google.com.)