Re: fix make update (issue 170000043 by jfrederich@gmail.com)
mar...@chromium.org
jrob...@google.com
Jens Frederich
On Nov 7, 2014 9:04 AM, "Jens Frederich" <jfred...@gmail.com> wrote:
>
> On Thu, Nov 6, 2014 at 8:46 PM, <jrob...@chromium.org> wrote:
> > lgtm.
> >
> > I see what you did and why it is needed. I think that I will make a
> > slight change to make explicit Makefile targets for update_frontend and
> > update_backend and have 'make update' call both in the proper sequence.
> > The reason is that your change would remove updating of backends.
> >
> > I will land this change for you.
> >
>
> Thanks.
>
> Jason, another Rietveld issue drives me crazy, maybe you have a hint
> for me. I'll do some small changes on the Go code review test suite.
> The test suite runs fine on my remote testing Rietveld instance. But
> on the local instance (App Engine Development Setup) I got always the
> following error :
>
> Issue created. URL: http://localhost:7777/1005
> Loading /1005/upload_complete/1006: urllib2.HTTPError: HTTP Error 500:
> Internal Server Error; trying again in 2 seconds.
> abort: HTTP Error 500: Internal Server Error
> hg change -i failed
>
> It seems the second upload command is to fast. Any idea what goes wrong?
>
On Rietveld the error is: Base file missing.
jfred...@gmail.com
I'd like you to review this change to
https://code.google.com/p/rietveld
https://codereview.appspot.com/170000043/
jfred...@gmail.com
Description:
fix make update
Please review this at http://codereview.appspot.com/170000043/
Affected files (+1, -1 lines):
M Makefile
Index: Makefile
===================================================================
--- a/Makefile
+++ b/Makefile
@@ -64,7 +64,7 @@
@echo "---[Updating REVISION]---"
@echo "$(VERSION_TAG)" >REVISION
-update: update_revision mapreduce update_backend
+update: update_revision mapreduce
@echo "---[Updating $(APPID)]---"
$(APPCFG) $(APPCFG_FLAGS) update . --oauth2 --application $(APPID)
--version $(VERSION)