Add j/k instead arrow keys and move j/k to h/l

[anatoly techtonik]

Hi,

Now that "Please give me back my arrow keys" is fixed
http://code.google.com/p/rietveld/issues/detail?id=382 I've finally
got a chance to play with keyboard navigation and, well, it is still
far from being convenient without a lot of practice. So..

I propose to change j/k for moving up and down the canvas, and assign
their previous function (moving to previous/next file to h/l). The
goal is to make navigation through the review without moving the
wrist. Currently it is still faster for me to use trackpad, so perhaps
you have better ideas what can be improved. For example, I'd add a
flash if the previous/next file is the last one, so that you will have
to press two times if you want to go back to issue page.

--
anatoly t.

[Guido van Rossum]

Hm. For me, and the many Googlers who use Rietveld, j/k and n/p are
pretty much hard-wired into our brains because so many other tools use
them (it all started with vi, and then GMail). Pleasedon't change
this!

> --
> You received this message because you are subscribed to the Google Groups "codereview-discuss" group.
> To post to this group, send email to coderevie...@googlegroups.com.
> To unsubscribe from this group, send email to codereview-disc...@googlegroups.com.
> For more options, visit this group at http://groups.google.com/group/codereview-discuss?hl=en.
>



--
--Guido van Rossum (python.org/~guido)

[anatoly techtonik]

What do j/k do in vi? I doubt they are switching files in the same
dir, and I am not touching n/p at all.

BTW, Gerrit, which as I understand is used by Googlers for Android
reviews, uses j/k for line-by-line navigation (even though they don't
have our mega scrolling patch).
https://codereview.qt-project.org/#patch,sidebyside,27004,1,src/plugins/git/gitorious/gitorious.cpp

[Guido van Rossum]

On Thu, May 24, 2012 at 4:04 PM, anatoly techtonik <tech...@gmail.com> wrote:
> What do j/k do in vi? I doubt they are switching files in the same
> dir, and I am not touching n/p at all.

More relevant is GMail. There j/k go up/down a line in the inbox, but
in the thread view they go to the next/previous thread (i.e. the same
what they would do in the inbox but while sticking to the thread view.

Please drop this argument.

[anatoly techtonik]

On Fri, May 25, 2012 at 2:26 AM, Guido van Rossum <gu...@python.org> wrote:
> On Thu, May 24, 2012 at 4:04 PM, anatoly techtonik <tech...@gmail.com> wrote:
>> What do j/k do in vi? I doubt they are switching files in the same
>> dir, and I am not touching n/p at all.
>
> More relevant is GMail. There j/k go up/down a line in the inbox, but
> in the thread view they go to the next/previous thread (i.e. the same
> what they would do in the inbox but while sticking to the thread view.
>
> Please drop this argument.

Ok. How A/B testing then?