Bazaar support

[Andi Albrecht]

I've started today a patch for upload.py to support Bazaar branches.
It turns out that it is very similar to the way upload.py handles
Subversion so it should be not much work to have a first working
version.

I'm going to upload it to codereview ASAP and it would be great if
someone here on the list who is more familiar with bzr than I could
test it.

[Ondrej Certik]

I can test it, but I only use bazaar sporadically. As to mercurial, it
turned out I am too busy with my thesis, so if anyone else is working
on it, go ahead. It's still on my todo list though.

Ondrej

[Andi Albrecht]

Here's the first working version: http://codereview.appspot.com/2891

On 12 Aug., 13:39, "Ondrej Certik" <ond...@certik.cz> wrote:
> On Mon, Aug 11, 2008 at 10:45 PM, Andi Albrecht
>

Great, feel free to give it a try ;-)

@Evan: The patch contains parts of your git patch. Have a look at it,
I think we should bring them together...

>
> Ondrej

[Ondrej Certik]

On Tue, Aug 12, 2008 at 5:11 PM, Andi Albrecht
<albrec...@googlemail.com> wrote:
>
> Here's the first working version: http://codereview.appspot.com/2891
>
> On 12 Aug., 13:39, "Ondrej Certik" <ond...@certik.cz> wrote:
>> On Mon, Aug 11, 2008 at 10:45 PM, Andi Albrecht
>>
>> <albrecht.a...@googlemail.com> wrote:
>>
>> > I've started today a patch for upload.py to support Bazaar branches.
>> > It turns out that it is very similar to the way upload.py handles
>> > Subversion so it should be not much work to have a first working
>> > version.
>>
>> > I'm going to upload it to codereview ASAP and it would be great if
>> > someone here on the list who is more familiar with bzr than I could
>> > test it.
>>
>> I can test it, but I only use bazaar sporadically. As to mercurial, it
>> turned out I am too busy with my thesis, so if anyone else is working
>> on it, go ahead. It's still on my todo list though.
>
> Great, feel free to give it a try ;-)
>

Done.

Ondrej

[Andi Albrecht]

Thanks for your instant reviews! I'll try to summarize and reply to
your comments here (omitting the inline comment to which I reply
later):

Ondrej said:
> I tested it and it works fine for me. It'd be a nice feature to add a support to
> upload several revisions at once, currently it merges them into one patch, but
> it should upload each patch within one issue to rietveld.

Yes, I've thought of this too but I came to no clear decision. So I
ommitted this feature in my patch. I was pretty unsure on how the
revisions that belongs to an issue should be defined by the user on
the command line and how I can get the right base files for such a
diff.
Finally I assumed, that someone who works on a branch has only changes
related to a single issue in this branch. After reading some things on
how people use bzr I came to this conclusion. In fact, there's no
restriction on how to use branches.
So, if there are more changes in a branch than the ones related to an
issue, then a command line option should allow something like '--rev
13,15,17-23' which means: use revison 13, 15 and 17-23 to create the
diff. But how can I get the base files for this diff?

Evan said:
> This looks good in general. My main concern is the way you handle the bzr
> command-line flags. I think it'd be better for only the bzr class to need to
> know about any bzr flags -- perhaps there's a way to pass unknown flags down to
> the VCS class?

Which command-line flags do you mean? In general I agree, only the bzr
class should know about bzr flags and additional flags specified on
the command line should be passed down to the VCS class.

Regarding the '--bzr_rev' flag: After viewing this patch again I think
that the doc for this flag is not clear enough. This flag doesn't
specify any bzr revisions, it is used to fetch the correct base files.
Or is there any better way to grab the info where the base files are
located, e.g. by using 'bzr info'?
When I uploaded the patch I've used '--bzr_rev=ancestor:../master' to
tell 'bzr cat ...' called in GetBaseFile() where it finds the bases
that patch is based on.