Groups
Groups
Sign in
Groups
Groups
codereview-discuss
Conversations
About
Send feedback
Help
Re: Implements a pseudo-patience-diff SequenceMatcher for Rietveld. (issue 6613055)
10 views
Skip to first unread message
mar...@chromium.org
unread,
Oct 5, 2012, 3:30:11 PM
10/5/12
Reply to author
Sign in to reply to author
Forward
Sign in to forward
Delete
You do not have permission to delete messages in this group
Copy link
Report message
Show original message
Either email addresses are anonymous for this group or you need the view member email addresses permission to view the original message
to macou...@chromium.org, coderevie...@googlegroups.com, re...@codereview-hr.appspotmail.com
I didn't review the algorithm but the rest of the change lgtm.
cc'ing the mailing list for more comments.
https://codereview.appspot.com/6613055/diff/2002/codereview/patiencediff.py
File codereview/patiencediff.py (right):
https://codereview.appspot.com/6613055/diff/2002/codereview/patiencediff.py#newcode18
codereview/patiencediff.py:18: """Provides s SequenceMatcher that
prefers longer "first" matches to longer
remove extra 's'
https://codereview.appspot.com/6613055/diff/2002/codereview/patiencediff.py#newcode22
codereview/patiencediff.py:22: def __init__(self, isjunk=None, a='',
b=''):
Remove lines 21-24, they are not needed.
https://codereview.appspot.com/6613055/diff/2002/codereview/patiencediff.py#newcode26
codereview/patiencediff.py:26: """Return list of triples describing
matching subsequences.
Returns
https://codereview.appspot.com/6613055/
Reply all
Reply to author
Forward
0 new messages