Chat notification

[Guido van Rossum]

All,

I've enabled changes to Rietveld that support notification of changes
to issues via chat. To enable this, you must go into your Settings tab
and check the "Notify by chat" checkbox (and submit), *AND* you must
accept the chat invitation in your chat client.

The implementation uses XMPP and requires that your email address is
the same as your chat address (to avoid spamming of random users). If
still you don't get the chats, it *may* also be possible that adding
coder...@appspot.com to your address book will help, though I have
not personally verified this.

The chat notifications are much briefer than email notifications --
basically a 1-2 word message, the Issue subject, and its URL. There
are notifications for some actions that don't trigger emails. In order
to make the chat notification debuggable, the user originating the
change will be notified as well.

Replying to chats from Rietveld does nothing except echo back a
message indicating it does nothing.

--
--Guido van Rossum (home page: http://www.python.org/~guido/)

[Stéfan van der Walt]

Hi Guido

2009/10/5 Guido van Rossum <gu...@python.org>:

> I've enabled changes to Rietveld that support notification of changes
> to issues via chat. To enable this, you must go into your Settings tab
> and check the "Notify by chat" checkbox (and submit), *AND* you must
> accept the chat invitation in your chat client.

Very cool! It works for me.

I noticed that there are no messages sent upon creation of an issue --
is that a design choice?

Cheers
Stéfan

[Guido van Rossum]

2009/10/5 Stéfan van der Walt <sjvd...@gmail.com>:

Kind of. IMO it makes sense since you have to set reviewers and send
the first email to start the review process.

[Stéfan van der Walt]

2009/10/5 Guido van Rossum <gu...@python.org>:

> Kind of. IMO it makes sense since you have to set reviewers and send
> the first email to start the review process.

Another way of looking at it is that, via Google's chat log, you have
a record of the progression of a ticket. The closing of the ticket is
reported, but not the creation, leaving a rather asymmetrical trail.
Also, I see no reason why the review process shouldn't be started via
XMPP.

Of course, it's no big deal -- this is a very useful feature for those
of us who mainly collaborate via chat!

Regards
Stéfan

[Guido van Rossum]

If you want this to change, please submit a patch (via Rietveld of
course) for my review.

2009/10/5 Stéfan van der Walt <sjvd...@gmail.com>:
>

[Gregory P. Smith]

On Mon, Oct 5, 2009 at 11:11 AM, Guido van Rossum <gu...@python.org> wrote:
>
> All,
>
> I've enabled changes to Rietveld that support notification of changes
> to issues via chat. To enable this, you must go into your Settings tab
> and check the "Notify by chat" checkbox (and submit), *AND* you must
> accept the chat invitation in your chat client.
>
> The implementation uses XMPP and requires that your email address is
> the same as your chat address (to avoid spamming of random users). If
> still you don't get the chats, it *may* also be possible that adding
> coder...@appspot.com to your address book will help, though I have
> not personally verified this.

Neat feature!

What would it take for this to support XMPP/Jabber/Google Talk chats
with an email address other than the one we are signed in to
codereview with? (My google login gmail.com address is not one I will
ever use for chat).

-Greg

[Guido van Rossum]

I'm reluctant to let users specify an alternate chat address since we
can't authenticate those, so they could be used to annoy random other
folks. The best solution may be for you to log in to codereview using
your preferred chat address and then CC that address on your code
reviews.