Can't post comments

Jimmy Wan

unread,

May 31, 2012, 1:44:16 PM5/31/12

to codereview-discuss

I can't seem to post my review comments. I've got 15 draft comments on
a review of about 45 files.

"Rietveld Code Review Tool
Sorry, an error occurred...

Unhandled exception.

Details: too many values to unpack [ValueError]

Please post a message to the discussion group if you have any
questions."

I'm using SVN.

This is the review if it matters:
http://codereview.appspot.com/6245073/

Guido van Rossum

unread,

May 31, 2012, 1:55:28 PM5/31/12

to Jimmy Wan, codereview-discuss

Hm, I see some log messages that probably match your report. They have
these messages:

[W] FetchBase: Error fetching
https://svn.collidermedia.com/svn/analytics/webservices/collider-server/trunk/collider-server/src/main/java/com/collider/service/AdSuggestService.java?rev=3126:
HTTP status 401

[E] ValueError:
Traceback (most recent call last):
File "/base/python_runtime/python_lib/versions/third_party/django-1.2/django/core/handlers/base.py",
line 100, in get_response
response = callback(request, *callback_args, **callback_kwargs)
File "/base/data/home/apps/s~codereview-hr/94.359135522911691243/codereview/views.py",
line 657, in login_wrapper
return func(request, *args, **kwds)
File "/base/data/home/apps/s~codereview-hr/94.359135522911691243/codereview/views.py",
line 741, in issue_wrapper
return func(request, *args, **kwds)
File "/base/data/home/apps/s~codereview-hr/94.359135522911691243/codereview/views.py",
line 694, in xsrf_wrapper
return func(request, *args, **kwds)
File "/base/data/home/apps/s~codereview-hr/94.359135522911691243/codereview/views.py",
line 2999, in publish
preview = _get_draft_details(request, comments)
File "/base/data/home/apps/s~codereview-hr/94.359135522911691243/codereview/views.py",
line 3152, in _get_draft_details
for old_line_no, new_line_no, line_text in file_lines:
ValueError: too many values to unpack

I'll look into this more when I've got some time. I've filed
http://code.google.com/p/rietveld/issues/detail?id=384 to track this.
Thanks for reporting!

--
--Guido van Rossum (python.org/~guido)

Jimmy Wan

unread,

May 31, 2012, 2:14:50 PM5/31/12

to codereview-discuss

Thanks for looking into this. I ran into a similar problem with this
review.
http://codereview.appspot.com/6257078/

We created a new patch that didn't include the top level directory
thinking that might cause a problem. It started working when I cut the
# of draft comments down to a very small number (3 or 4).

On May 31, 12:55 pm, Guido van Rossum <gu...@python.org> wrote:
> On Thu, May 31, 2012 at 10:44 AM, Jimmy Wan <ji...@collidermedia.com> wrote:
> > I can't seem to post my review comments. I've got 15 draft comments on
> > a review of about 45 files.
>
> > "Rietveld Code Review Tool
> > Sorry, an error occurred...
>
> > Unhandled exception.
>
> > Details: too many values to unpack [ValueError]
>
> > Please post a message to the discussion group if you have any
> > questions."
>
> > I'm using SVN.
>
> > This is the review if it matters:
> >http://codereview.appspot.com/6245073/
>
> Hm, I see some log messages that probably match your report. They have
> these messages:
>

> [W] FetchBase: Error fetchinghttps://svn.collidermedia.com/svn/analytics/webservices/collider-serv...

> HTTP status 401
>
> [E] ValueError:
> Traceback (most recent call last):

> File "/base/python_runtime/python_lib/versions/third_party/django-1.2/django/cor e/handlers/base.py",

> line 100, in get_response
> response = callback(request, *callback_args, **callback_kwargs)