Does codereviews for google apps support ssl connections?

28 views
Skip to first unread message

alex.sheive

unread,
Dec 17, 2011, 3:01:03 PM12/17/11
to codereview-discuss
I can't find any way to enforce, or even allow, connecting to reitveld
like https://codereviews.somedomain.com

anatoly techtonik

unread,
Dec 19, 2011, 12:47:42 PM12/19/11
to alex.sheive, codereview-discuss

Have you tried 'upload.py --help'?

On Dec 17, 2011 11:07 PM, "alex.sheive" <alex....@gmail.com> wrote:

I can't find any way to enforce, or even allow, connecting to reitveld
like https://codereviews.somedomain.com


--
You received this message because you are subscribed to the Google Groups "codereview-discuss" group.
To post to this group, send email to coderevie...@googlegroups.com.
To unsubscribe from this group, send email to codereview-disc...@googlegroups.com.
For more options, visit this group at http://groups.google.com/group/codereview-discuss?hl=en.

alex.sheive

unread,
Dec 19, 2011, 1:09:48 PM12/19/11
to codereview-discuss
To be more clear -- apps like calendar, gmail, etc, let you enforce
that they must be accessed through ssl. For instance, you can enforce
that any user going to http://mail.somedomain.com is redirected to
https://mail.somedomain.com.

However, for codereviews, using ssl doesn't even seem possible, much
less enforceable. https://codereviews.somedomain.com simply doesn't
work, and there is no option to enforce using https.

I assume I'm just missing something as clearly there are many projects
for which code going over the network in plain text is a deal breaker.

On Dec 19, 7:47 pm, anatoly techtonik <techto...@gmail.com> wrote:
> Have you tried 'upload.py --help'?
>

> On Dec 17, 2011 11:07 PM, "alex.sheive" <alex.she...@gmail.com> wrote:
>
> I can't find any way to enforce, or even allow, connecting to reitveld

> likehttps://codereviews.somedomain.com

alex.sheive

unread,
Dec 20, 2011, 5:17:10 AM12/20/11
to codereview-discuss
For the record, there was a reply that is not shown here that
contained the answer. To summarize:

The Google Apps version of Rietveld does not support SSL on custom
domains. Support for custom SSL in App Engine is currently on
whitelist only, and there are no plans to allow domain owners to
upload SSL keys to be used on Rietveld-for-your-domain.
You can always set up your own SSL version of Reitveld on
something.appspot.com which would allow for use and enforcement of
https.

On Dec 19, 7:09 pm, "alex.sheive" <alex.she...@gmail.com> wrote:
> To be more clear -- apps like calendar, gmail, etc, let you enforce
> that they must be accessed through ssl.  For instance, you can enforce

> that any user going tohttp://mail.somedomain.comis redirected tohttps://mail.somedomain.com.


>
> However, for codereviews, using ssl doesn't even seem possible, much

> less enforceable.  https://codereviews.somedomain.comsimply doesn't

anatoly techtonik

unread,
Dec 20, 2011, 5:37:54 AM12/20/11
to alex.sheive, codereview-discuss
Thanks for heads up.  I guess the same stuff applies to all apps on custom domain - http://code.google.com/appengine/kb/general.html#https
--
anatoly t.

Vincent Zanotti

unread,
Dec 20, 2011, 8:11:06 PM12/20/11
to codereview-discuss
Sorry, the invisible reply was mine, I didn't use the right sender address, and Google Groups ate it :)

- Vincent

On Mon, Dec 19, 2011 at 5:57 PM, Vincent Zanotti <vincent...@google.com> wrote:
Hey Alex!

The Google Apps version of Rietveld does not support SSL on custom domains. Support for custom SSL in App Engine is currently on whitelist only, and I don't have any plans to allow domain owners to upload SSL keys to be used on Rietveld-for-your-domain (would that actually be used?).

If you care much about having an SSL-only instance of Rietveld, you can always set up your own, on something.appspot.com. You would be able to use https, and since it would be your own deployment, you could even force the use of SSL for all requests.

Cheers,
Vincent


On Sat, Dec 17, 2011 at 8:01 PM, alex.sheive <alex....@gmail.com> wrote:
I can't find any way to enforce, or even allow, connecting to reitveld
like https://codereviews.somedomain.com
--
You received this message because you are subscribed to the Google Groups "codereview-discuss" group.
To post to this group, send email to coderevie...@googlegroups.com.
To unsubscribe from this group, send email to codereview-disc...@googlegroups.com.
For more options, visit this group at http://groups.google.com/group/codereview-discuss?hl=en.




--
Vincent Zanotti
Adsense Engineering - Google UK Limited

Registered Office: Belgrave House, 76 Buckingham Palace Road, London SW1W 9TQ
Registered in England Number: 3977902



--
Vincent Zanotti
Adsense Engineering - Google UK Limited

Registered Office: Belgrave House, 76 Buckingham Palace Road, London SW1W 9TQ
Registered in England Number: 3977902
Reply all
Reply to author
Forward
0 new messages