Re: Allow upload.py to upload binary files that are not images. (issue 6221063)

11 views
Skip to first unread message

mar...@chromium.org

unread,
May 22, 2012, 4:28:12 PM5/22/12
to rog...@chromium.org, coderevie...@googlegroups.com, re...@codereview-hr.appspotmail.com
lgtm, cc'ing the ML in case there's any opinion.

We need the binary files to be uploaded so they can be downloaded by the
commit queue.

http://codereview.appspot.com/6221063/

tech...@gmail.com

unread,
May 23, 2012, 1:50:41 PM5/23/12
to rog...@chromium.org, mar...@chromium.org, coderevie...@googlegroups.com, re...@codereview-hr.appspotmail.com
How do you plan to fight with spamming tracker with random binary stuff
to death? I can immediately see it as a free hosting.

http://codereview.appspot.com/6221063/

Guido van Rossum

unread,
May 23, 2012, 1:52:32 PM5/23/12
to rog...@chromium.org, mar...@chromium.org, tech...@gmail.com, coderevie...@googlegroups.com, re...@codereview-hr.appspotmail.com
Let's cross that bridge when we get to it. Note that since this is a
pure client-side change, the actual ability to upload binaries hasn't
changed. Also note that files are limited to 1MB, not very attractive
for spammers.
> --
> You received this message because you are subscribed to the Google Groups
> "codereview-discuss" group.
> To post to this group, send email to coderevie...@googlegroups.com.
> To unsubscribe from this group, send email to
> codereview-disc...@googlegroups.com.
> For more options, visit this group at
> http://groups.google.com/group/codereview-discuss?hl=en.
>



--
--Guido van Rossum (python.org/~guido)

anatoly techtonik

unread,
May 23, 2012, 2:11:37 PM5/23/12
to Guido van Rossum, rog...@chromium.org, mar...@chromium.org, coderevie...@googlegroups.com, re...@codereview-hr.appspotmail.com
On Wed, May 23, 2012 at 8:52 PM, Guido van Rossum <gu...@python.org> wrote:
> Let's cross that bridge when we get to it. Note that since this is a
> pure client-side change, the actual ability to upload binaries hasn't
> changed. Also note that files are limited to 1MB, not very attractive
> for spammers.

All right. 1MB is a real showstopper.
Reply all
Reply to author
Forward
0 new messages