nickname in reviewers list

2 views
Skip to first unread message

Evan Martin

unread,
Sep 26, 2008, 2:23:56 PM9/26/08
to coderevie...@googlegroups.com, John Abd-El-Malek
I notice there was some recent changes with nicknames in the reviewer list.

I think it might be a bit broken. Here's what I did, on codereview.appspot.com:
1) Upload a new review (http://codereview.appspot.com/6242), click the
"edit issue" link. Typed john.ab...@gmail.com as the reviewer.
2) Clicked "publish+mail comments". It shows JohnA (his nickname on
Rietveld) in the reviewers field.
3) When I submitted that form, I got an error about there being no
such nickname. I had to type in his email address again.

Andi Albrecht

unread,
Sep 26, 2008, 3:59:23 PM9/26/08
to coderevie...@googlegroups.com
Yes, it's broken ATM. The nicknames are lowercased before the
datastore query. So in your case it searches for johna instead JohnA.
I've uploaded a patch on codereview (don't have the issue number
now...)
Reply all
Reply to author
Forward
0 new messages