RSS feed code needs to be updated

[Marc-Antoine Ruel]

http://codereview.appspot.com/rss/feed/foo returns 500 instead of 404. The error is in django_1_2/django/contrib/syndication/views.py line 225. It raises a Http404 but it is not property converted into an error code. The function says that this view is deprecated and shouldn't be used anymore.

I'm not using RSS personally so I don't care that much but it's making the logs noisy so if anyone cares, it'd be nice if that was eventually fixed. I'm just raising in case somebody cares about the RSS feed.

M-A

[Andi Albrecht]

Thanks for pointing at this issue.

It's not how we add the RSS feeds. IMO we do it as documented, the
deprecation warning you've mentioned seem to point to an older API.

The real problem was that we catch exception to provide a nice error
message and 404 *is* an exception. I've uploaded a changeset:
http://codereview.appspot.com/5532116

Regards,

Andi

> --
> You received this message because you are subscribed to the Google Groups
> "codereview-discuss" group.
> To post to this group, send email to coderevie...@googlegroups.com.
> To unsubscribe from this group, send email to
> codereview-disc...@googlegroups.com.
> For more options, visit this group at
> http://groups.google.com/group/codereview-discuss?hl=en.