Inlining the patch in email body

0 views
Skip to first unread message

ajaksu

unread,
Mar 10, 2009, 12:50:31 PM3/10/09
to codereview-discuss
Hi,
Does anyone know what variable controls whether the patch is inlined
in an email? I caused both behaviors[1] (inlining or not), but am a
little unsure about how and would rather not have to go back to find
out.

Sorry for being lazy, I'll provide patches for open issues (next
month?) as a compensation ;)

Regards,
Daniel

[1] http://psf.upfronthosting.co.za/roundup/meta/issue247

Andi Albrecht

unread,
Mar 10, 2009, 4:27:29 PM3/10/09
to coderevie...@googlegroups.com
Hi Daniel,

only diffs with less then 100 lines are inlined in the emails (see
codereview.views._get_affected_files() ).

Regards,

Andi

ajaksu

unread,
Mar 10, 2009, 10:13:51 PM3/10/09
to codereview-discuss
Hi Andi,

Andi Albrecht wrote:
> only diffs with less then 100 lines are inlined in the emails (see
> codereview.views._get_affected_files() ).

Thanks a lot!

I guess I won't mess with this right now, but here's a small note for
if/when I get back to it...
Code path is:
_make_new <- _make_message <- _get_mail_template <- _get_mail_template
<- _get_affected_files

And we can intercept context['patch'] as late as _make_message, before
mail.send_mail.

Best regards,
Daniel
Reply all
Reply to author
Forward
0 new messages