Why did we add --diff-cmd=diff to the svn diff call in upload.py?

1 view
Skip to first unread message

Guido van Rossum

unread,
Jul 9, 2008, 6:00:47 PM7/9/08
to codereview-discuss
Does anyone recall why we added --diff-cmd=diff to the svn diff
invocation? The comment for r137 is not helpful. It is causing
problems on Windows, see issue 30.

Thomas Van Lenten

unread,
Jul 9, 2008, 6:23:02 PM7/9/08
to coderevie...@googlegroups.com
pure guess: to override someone's env settings for what svn should use for diffs?  ie-force the text diff you want.

TVL

Andi Albrecht

unread,
Jul 10, 2008, 12:13:40 AM7/10/08
to coderevie...@googlegroups.com
2008/7/10 Thomas Van Lenten <thom...@gmail.com>:

> pure guess: to override someone's env settings for what svn should use for
> diffs? ie-force the text diff you want.
Yes, that was the reason for adding this option, but I can't remember
where we discussed it and who pointed it out.
Reply all
Reply to author
Forward
0 new messages