Remove command from sideMenu issue

[candid...@gmail.com]

I'm having some trouble modifying SideMenu commands since the last JavaSE update.

  Test case below shows the problem. Expected result is: clicking on the command will remove it. Actual result is: clicking in the command doesn't seem to do anything. 

    Toolbar.setGlobalToolbar(true);

    Form hi = new Form("Entrada");

    Style s = UIManager.getInstance().getComponentStyle("TitleCommand");

    FontImage icon = FontImage.createMaterial(FontImage.MATERIAL_WARNING, s);

    Command cmd = hi.getToolbar().addCommandToRightBar("Bla", null, (e) -> Log.p("Bla"));

    hi.getToolbar().addCommandToSideMenu("Remove", null, (e) -> {

      hi.removeCommand(cmd);

      hi.revalidate();

    });

    

    Also, after adding commands to the sidebar, hi.getCommandCount() returns 0.

    

    Is this a deliberate change? Is there a better way of making "dynamic" SideMenu's? (being able to remove certain commands and put new ones).

[Shai Almog]

Thanks, this is probably a regression due to the recent migration to on-top side menu: https://www.codenameone.com/blog/pixel-perfect-on-top-menu.html

Please file an issue we'll try to fix this before the code freeze.

[daniel...@bitxenio.com]

Hi Shai

I have filled a Issue:

https://github.com/codenameone/ToolbarSidemenu/issues/1

Best Regards

[Shai Almog]

Thanks this should be fixed in git and we'll push out an update later today. However, for future reference the place for Codename One issues is here: http://github.com/codenameone/CodenameOne/issues/

Sorry I should have clarified that ;-)

[ka...@bitxenio.com]

Hi Shai

we received and notification from github thats the issue was fixed, but the issue still remains.

I updated the issue post:

https://github.com/codenameone/ToolbarSidemenu/issues/1

Next Issues we will open in http://github.com/codenameone/CodenameOne/issues/

Best Regards

[Shai Almog]

Hi,

did you use "update client libs" in Codename One Settings under "Basic" to fetch the latest update?

[ka...@bitxenio.com]

Yes I did.

Best Regards

[Shai Almog]

We made another fix for this. When we push out a new client lib it should be fixed. We'll do that today or tomorrow.

[avner...@gmail.com]

Hi Shai,

I posted more issues on the new side menu implementation
Thanks

[Shai Almog]

Hi,

I noticed you posted it in one of our demo projects. I disabled issue tracking there as it's clearly not the place for Codename One issues.

All issues should go here: http://github.com/codenameone/CodenameOne/issues/

You mentioned a couple of things, the former is already fixed and was fixed yesterday so make sure you updated the libs (notice we released more than one update over the weekend).

The RTL support issue is an RFE we should address, it should be easier to extend the on-top menu now that it's the default but that will have to go into the next update.