Get TextField value - not using GUI builder

[Dan]

I'm using Eclipse and writting things by hand without the use of the GUI builder.

Here's my main form:

public class WelcomeForm extends Form {

    Button btnBrowse;
    Button btnLogin;
    Label lblUsername;
    Label lblPassword;
    Label lblErrorMessage;   
    TextField txtUsername;
    TextField txtPassword;
   
    public WelcomeForm(){
        init();
    }
   
    private void init(){
        btnBrowse = new Button("Browse Games");
        btnLogin = new Button("Login");
        btnBrowse.addActionListener(new BrowseButtonActionListener(this));
        btnLogin.addActionListener(new LoginButtonActionListener(this));
       
        lblUsername = new Label("Username:");
        lblPassword = new Label("Password:");
        lblErrorMessage = new Label("");
       
        txtUsername = new TextField();
        txtPassword = new TextField();

        setLayout(new FlowLayout(Component.CENTER));
        setTitle("My title");
        addComponent(lblUsername);
        addComponent(txtUsername);
        addComponent(lblPassword);
        addComponent(txtPassword);
        addComponent(btnLogin);
        addComponent(lblErrorMessage);
        addComponent(btnBrowse);
    }
}

Here is my listener:

public class LoginButtonActionListener implements ActionListener {

    Form frm;

    public LoginButtonActionListener(Form frm) {
        this.frm = frm;
    }

    public void actionPerformed(ActionEvent evt) {
        //looking at reading form elements here
        System.out.println("Login button clicked!!");
    }
}

How would I get at the TextField in the WelcomeForm class via the listener?

On a side note, how typical is it to develop in CN1 this way?

[Dan]

Did a bit of digging and this seems to work in the actionPerformed method:

TextField f = (TextField)this.frm.getContentPane().getComponentAt(1);

You do have to know the indexes though. Again, how typical is this sort of approach?

[Maaike]

You can just do txtUsername.getText() within actionPerformed(). Or didn't you use it as an inline class? Otherwise, I would say make getters so you can access the textfield with getTxtUsername(); 

(I would also make my attributes private because they now can be changed outside the class by other methods within the same package, but maybe that has a reason. Since your attributes are not private, you can maybe just access them from the class, welcomeForm.txtUsername).

[Shai Almog]

You should use:

     TextField tf = (TextField)evt.getSource();
    
Relying on the position of the component within the content pane is pretty fragile.

We program by hand quite a bit e.g. see the kitchen sink demo.

[Maaike]

Since the listener is on the button, don't you get the button with evt.getSource() instead of the textfield?

[Shai Almog]

Yes you are correct, I misread that.
In that case the only reasonable suggest is the one you made.