ImageViewer panning out of boundaries when zooming

[Carlos Verdier]

Hi

I have noticed a chage of behavior on ImageViewer recently. Now, when zooming, the image can go offlimits when panning, which is not convinient at all.

Could you please take a look? Here is a test case:

        Form hi = new Form("Viewer", new BorderLayout());
        FontImage img = FontImage.createMaterial(FontImage.MATERIAL_IMAGE, UIManager.getInstance().getComponentStyle("Label"), 20f);      
        ImageViewer viewer = new ImageViewer(img) {
            int cilckCount = 0;
            @Override
            public void pointerReleased(int x, int y) {
                cilckCount ++;
                new UITimer(() -> cilckCount = 0).schedule(500, false, hi);
                if (cilckCount > 1) {
                    cilckCount = 0;                    
                    if (this.getZoom() > 1) {
                        this.setZoom(1);
                    } else {
                        this.setZoom(2);
                    }
                }
            }            
        };
        hi.add(BorderLayout.CENTER, viewer);
        hi.show();    

Thanks.

[Shai Almog]

Hi,

If you revert this fix is the behavior improved?
https://github.com/codenameone/CodenameOne/commit/cd2951e61f685ed435203e1fad5c6eb45e222f9e#diff-472a53741e3367bcb92ab7ddfdce4d9957f1339bfdd0d9d011f069adace41ef0

[Carlos Verdier]

Yes, it works as expected reverting the fix.

[Shai Almog]

Thanks, we'll look into it.

[Carlos Verdier]

Has this problem been addressed? I still see the same issue.

[Shai Almog]

I don't know. I'll check.

[CodenameOne Discussions]

I tried your test case and can't seem to reproduce what you're describing.  Can you provide some instructions on how to use your test case to demonstrate the issue?

[Carlos Verdier]

Just double tap on the image to zoom and then pan it around. You will see that you can pan outside the boundaries, which should not happen. If you style the form background color, the failure is more evident.

If you revert the changes that Shai points out above, it works as it should.

[Steve Hannah]

OK.  I see what you mean.  I should have a fix for Friday.

On Mon, Mar 8, 2021 at 11:06 AM Carlos Verdier <cver...@gmail.com> wrote:

Just double tap on the image to zoom and then pan it around. You will see that you can pan outside the boundaries, which should not happen. If you style the form background color, the failure is more evident.

If you revert the changes that Shai points out above, it works as it should.

--
You received this message because you are subscribed to the Google Groups "CodenameOne Discussions" group.
To unsubscribe from this group and stop receiving emails from it, send an email to codenameone-discu...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/codenameone-discussions/caf919f8-d5ea-47e8-8a96-a975762b483co%40googlegroups.com.

--

Steve Hannah

Software Developer

Codename One

http://www.codenameone.com

[Carlos Verdier]

Great, thank you.

[Steve Hannah]

Should be fixed now (in git).

https://github.com/codenameone/CodenameOne/commit/7df3509c3091d30a9547caf222e0e00cd3ccee93

On Wed, Mar 10, 2021 at 6:16 AM Carlos Verdier <cver...@gmail.com> wrote:

Great, thank you.

--
You received this message because you are subscribed to the Google Groups "CodenameOne Discussions" group.
To unsubscribe from this group and stop receiving emails from it, send an email to codenameone-discu...@googlegroups.com.

To view this discussion on the web visit https://groups.google.com/d/msgid/codenameone-discussions/ebdfeae1-107f-4e23-abcb-4384653cd5b8o%40googlegroups.com.