Re: Reopen 7833
14 views
Skip to first unread message
Thomas Broyer
Mar 22, 2013, 10:31:26 AM3/22/13
to Reuben Firmin, codehaus-mojo-gwt-...@googlegroups.com
[+cc codehaus-mojo-gwt-maven-plugin-users]
On Thu, Mar 21, 2013 at 8:37 PM, Reuben Firmin <r...@flavor8.com> wrote:
> Hi, I've tracked down 7833 to one of two commits - the only two that had
> anything to do with the build directory.
>
> Happy to do more debugging, but I don't know where to start. Wanted to draw
> your attention to the fact that it is still a bug in any case...so please
> reopen 7833.
You rightfully pinpoint the change about MGWT-290, as I already
commented a couple weeks ago on MGWT-350.
I understand this is a breaking change, but I really do think the
previous behavior was broken and this one is "right": whenever you
edit a resource, run "mvn process-resources" (M2Eclipse runs it
automatically whenever you touch a file, FYI) before you hit F5 in
your browser.
I foresee changes that could mitigate this (see below), so MGWT-350
could possibly be reopened, but that doesn't mean it'll be fixed any
time soon.
* add resources directory for which filtering is not turned on *and*
don't have any includes/excludes to the classpath, so "mvn
process-resources" isn't needed for those folders.
* a deeper change could be to monitor file changes and automatically
re-run process-resources (or actually maybe rather process-classes so
that changes to server-side classes would be taken into account too,
despite mixing client and server in the same Maven module being
considered –by me at least– a bad practice).
What I'd really want is a gwt:run that is multi-module-aware. I think
there are many good ideas to borrow from the jszip-maven-plugin.
In any case, I won't reopen issue 7833 as you're talking here about
the org.codehaus.mojo:gwt-maven-plugin, not GWT proper.
Last, but not least, I'm not *the* maintainer for the plugin, it's
supposed to be a community thing, so you should bring these requests
to the project's mailing list (and/or in this case, commenting on the
issue at codehaus.org):
https://groups.google.com/d/forum/codehaus-mojo-gwt-maven-plugin-users
--
Thomas Broyer
/tɔ.ma.bʁwa.je/
On Thu, Mar 21, 2013 at 8:37 PM, Reuben Firmin <r...@flavor8.com> wrote:
> Hi, I've tracked down 7833 to one of two commits - the only two that had
> anything to do with the build directory.
>
> Happy to do more debugging, but I don't know where to start. Wanted to draw
> your attention to the fact that it is still a bug in any case...so please
> reopen 7833.
You rightfully pinpoint the change about MGWT-290, as I already
commented a couple weeks ago on MGWT-350.
I understand this is a breaking change, but I really do think the
previous behavior was broken and this one is "right": whenever you
edit a resource, run "mvn process-resources" (M2Eclipse runs it
automatically whenever you touch a file, FYI) before you hit F5 in
your browser.
I foresee changes that could mitigate this (see below), so MGWT-350
could possibly be reopened, but that doesn't mean it'll be fixed any
time soon.
* add resources directory for which filtering is not turned on *and*
don't have any includes/excludes to the classpath, so "mvn
process-resources" isn't needed for those folders.
* a deeper change could be to monitor file changes and automatically
re-run process-resources (or actually maybe rather process-classes so
that changes to server-side classes would be taken into account too,
despite mixing client and server in the same Maven module being
considered –by me at least– a bad practice).
What I'd really want is a gwt:run that is multi-module-aware. I think
there are many good ideas to borrow from the jszip-maven-plugin.
In any case, I won't reopen issue 7833 as you're talking here about
the org.codehaus.mojo:gwt-maven-plugin, not GWT proper.
Last, but not least, I'm not *the* maintainer for the plugin, it's
supposed to be a community thing, so you should bring these requests
to the project's mailing list (and/or in this case, commenting on the
issue at codehaus.org):
https://groups.google.com/d/forum/codehaus-mojo-gwt-maven-plugin-users
--
Thomas Broyer
/tɔ.ma.bʁwa.je/
Reply all
Reply to author
Forward
0 new messages