Hi André
That is a rather neat patch, if you also would add the new property in the configuration capability then it is even super 😉
Would you want yo create a PR into the master for it? We could then easily get it in.
Regards
S. Ali Tokmen https://ali.tokmen.com/ https://contact.ali.tokmen.com/
--
Codehaus Cargo - https://codehaus-cargo.github.io/
---
You received this message because you are subscribed to the Google Groups "Codehaus Cargo" group.
To unsubscribe from this group and stop receiving emails from it, send an email to codehaus-carg...@googlegroups.com.
To view this discussion visit https://groups.google.com/d/msgid/codehaus-cargo/86129dd0-8152-42eb-8d0e-cba4ce773300n%40googlegroups.com.
Hi André
Perfect, I now created https://codehaus-cargo.atlassian.net/browse/CARGO-1649, merged https://github.com/codehaus-cargo/cargo/pull/650 and also did slight adaptations via https://github.com/codehaus-cargo/cargo/commit/e5942a09d3bf5efab11472403f85b2f779fcee8f.
Let us see what the CI builds will say: https://codehaus-cargo.semaphoreci.com/workflows/3ed98bc5-2597-4d2d-ad00-cdac49b8fa9a?pipeline_id=7a55326a-ff62-4191-9eae-52a2df48e62b
Regards
S. Ali Tokmen https://ali.tokmen.com/ https://contact.ali.tokmen.com/
To view this discussion visit https://groups.google.com/d/msgid/codehaus-cargo/d637bfa3-c78e-49ef-9821-1e7b77d6ec63n%40googlegroups.com.
Hi André
Thanks for the nice words, and for your great contribution 🙂
The new version 1.10.24 is out, enjoy!
Regards
S. Ali Tokmen https://ali.tokmen.com/ https://contact.ali.tokmen.com/
To view this discussion visit https://groups.google.com/d/msgid/codehaus-cargo/a9720e3d-b568-4628-88a2-3e676eb101b1n%40googlegroups.com.
<xmlReplacements>
<xmlReplacement>
<file>conf/server.xml</file>
<xpathExpression>//Server/Service/Connector[@port='${cargo.servlet.port}']</xpathExpression>
<attributeName>maxPartCount</attributeName>
<value>2000</value>
</xmlReplacement>
</xmlReplacements>
Hi Johan
Interesting that you picked that, and nice hint!
I recently checked in https://github.com/codehaus-cargo/cargo/commit/225f2636f1c653f365d5429871b49b339e9b1c16 to 1) support also on Tomcat 9.x embedded and 2) extend the support to standalone (XML-driven) configurations.
When Codehaus Cargo 1.10.25 is out, the extensions will be included.
Regards
S. Ali Tokmen https://ali.tokmen.com/ https://contact.ali.tokmen.com/
To view this discussion visit https://groups.google.com/d/msgid/codehaus-cargo/38b5bc20-9f5b-4963-a8b5-498bb1ae0a0fn%40googlegroups.com.