Tomcat embedded and maxPartCount setup

[André Santos]

Hi,

In one of our current projects, we are utilizing Tomcat 10.x, and we've encountered a limitation with the default maxPartCount value, which is currently hardcoded to 50 in the org.apache.catalina.connector.Connector.

This default is quite restrictive for our use case, and unfortunately, it is not currently configurable via plugin configuration.

We would like to request that a configurable property be introduced in a future release, allowing users to adjust the maxPartCount.

This would greatly enhance flexibility and allow applications with larger multipart form data to function without custom workarounds.

This is a simple solution for the issue : https://github.com/andre-santos-infoniqa/cargo/pull/1


Best regards.

[S. Ali Tokmen]

Hi André

That is a rather neat patch, if you also would add the new property in the configuration capability then it is even super 😉

Would you want yo create a PR into the master for it? We could then easily get it in.

Regards

S. Ali Tokmen
https://ali.tokmen.com/
https://contact.ali.tokmen.com/

--
Codehaus Cargo - https://codehaus-cargo.github.io/
---
You received this message because you are subscribed to the Google Groups "Codehaus Cargo" group.
To unsubscribe from this group and stop receiving emails from it, send an email to codehaus-carg...@googlegroups.com.
To view this discussion visit https://groups.google.com/d/msgid/codehaus-cargo/86129dd0-8152-42eb-8d0e-cba4ce773300n%40googlegroups.com.

[André Santos]

Hi,
I already updated the code in order to receive the prop setting system properties.

this is the PR changed: https://github.com/andre-santos-infoniqa/cargo/pull/1

I don't have write access to your repo, that's why I forked, but, please, you can use my changes.


Best regards.

[S. Ali Tokmen]

Hi André

Perfect, I now created https://codehaus-cargo.atlassian.net/browse/CARGO-1649, merged https://github.com/codehaus-cargo/cargo/pull/650 and also did slight adaptations via https://github.com/codehaus-cargo/cargo/commit/e5942a09d3bf5efab11472403f85b2f779fcee8f.

Let us see what the CI builds will say: https://codehaus-cargo.semaphoreci.com/workflows/3ed98bc5-2597-4d2d-ad00-cdac49b8fa9a?pipeline_id=7a55326a-ff62-4191-9eae-52a2df48e62b

Regards

S. Ali Tokmen
https://ali.tokmen.com/
https://contact.ali.tokmen.com/

To view this discussion visit https://groups.google.com/d/msgid/codehaus-cargo/d637bfa3-c78e-49ef-9821-1e7b77d6ec63n%40googlegroups.com.

[André Santos]

Hi,

Cool, thanks for the improvements too.

I use the plugin a lot, you did a great job, thank you very much.
I'll be waiting for the next version to be released.

Best regards,
André

[S. Ali Tokmen]

Hi André

Thanks for the nice words, and for your great contribution 🙂

The new version 1.10.24 is out, enjoy!

Regards

S. Ali Tokmen
https://ali.tokmen.com/
https://contact.ali.tokmen.com/

To view this discussion visit https://groups.google.com/d/msgid/codehaus-cargo/a9720e3d-b568-4628-88a2-3e676eb101b1n%40googlegroups.com.