Feature Request: Support cargo.tomcat.connector.maxParameterCount property

[Phuoc Nguyen]

Hi Codehaus Cargo team,

First, thank you for the recent addition of cargo.tomcat.connector.maxPartCount in 1.10.25 — it's a great improvement.

 

I'd like to request a similar addition: support for cargo.tomcat.connector.maxParameterCount, which maps to Tomcat's connector attribute maxParameterCount (defaults to 10,000).

Adding cargo.tomcat.connector.maxParameterCount to TomcatPropertySet, wired the same way as maxPartCount, would allow users to configure this via:

 <cargo.tomcat.connector.maxParameterCount>10000</cargo.tomcat.connector.maxParameterCount>

Thank you for your time and for maintaining this project.

Best regards

[S. Ali Tokmen]

Hi Phuoc

Thanks for the suggestion :)

Codehaus Cargo has always been a PR-friendly project, may I suggest you attempt to implement this and push a PR?

For inspiration, check out https://github.com/search?q=repo%3Acodehaus-cargo%2Fcargo+CONNECTOR_MAX_PART_COUNT&type=code (just 4 files to update to add the new suggested parameter!).

Kind regards

S. Ali Tokmen
https://ali.tokmen.com/
https://contact.ali.tokmen.com/

--
Codehaus Cargo - https://codehaus-cargo.github.io/
---
You received this message because you are subscribed to the Google Groups "Codehaus Cargo" group.
To unsubscribe from this group and stop receiving emails from it, send an email to codehaus-carg...@googlegroups.com.
To view this discussion visit https://groups.google.com/d/msgid/codehaus-cargo/f530b0a6-5155-475b-b126-a152e1c7d4f7n%40googlegroups.com.

[Phuoc Nguyen]

Hello Codehaus Cargo team,

I created a PR for it: https://github.com/codehaus-cargo/cargo/pull/692

Best regards

[S. Ali Tokmen]

Hi Phuoc

Great PR - Accepted! 🙂

I also created https://codehaus-cargo.atlassian.net/browse/CARGO-1656 for it, I noticed there's also a few other updates from other containers which I merged, once the CI is happy I'll release a new version of Codehaus Cargo.

Thank you

S. Ali Tokmen
https://ali.tokmen.com/
https://contact.ali.tokmen.com/

To view this discussion visit https://groups.google.com/d/msgid/codehaus-cargo/f1770ff6-5ac9-4e06-9ecf-a0624d2dc7e4n%40googlegroups.com.