Major (stupid) Bug in DDASLLogger. Lumberjack quality deteriorating recently.

[Matt G]

On March 12, yonglam made the following change to [DDASLLogger logMessage]:

From:

        asl_log(client, NULL, aslLogLevel, "%s", msg);

to:

       aslmsg m = asl_new(ASL_TYPE_MSG);

        asl_set(m, ASL_KEY_READ_UID, "501");

        asl_log(client, m, aslLogLevel, "%s", msg);

        asl_free(m);

But this is really stupid as that means that only a user with id 501 can actually see the messages in the log.

This is really disappointing as:

1. The author gave no clue as to why they made this change. Useless commit messages such as "Update DDASLLogger.m" don;t help

2. The author gave no thought to what he was doing. Anyone with an inkling of understanding or user accounts would have immediately realised this was a very fragile thing to do.

3. It means there is no review or oversight of changes being made to LumberJack.