are we mandating go 1.12 ?

15 views
Skip to first unread message

Andrei Matei

unread,
Jun 24, 2019, 3:57:52 PM6/24/19
to Peter Mattis, Raphael 'kena' Poss, Ben Darnell, CockroachDB
Y'all,

Raphael recently merged a PR using the new go 1.12 strings.ReplaceAll() function (albeit in a lowly test).
So far the word has been that we're not mandating go 1.12, although the builder has been updated to go 1.12.5.
So the pressure is upon us; which way do we tilt?

- a_m


Ben Darnell

unread,
Jun 24, 2019, 4:09:57 PM6/24/19
to Andrei Matei, Peter Mattis, Raphael 'kena' Poss, CockroachDB
We should require go 1.12. In general we should advance the minimum version very soon after updating the builder image (perhaps at the same time). If we're going to spend significant periods of time supporting two different Go versions, we should test with both builder images in CI, but I don't think that's worth it.

-Ben

Andrei Matei

unread,
Jun 24, 2019, 4:17:17 PM6/24/19
to Ben Darnell, Peter Mattis, Raphael 'kena' Poss, CockroachDB
Reply all
Reply to author
Forward
0 new messages