small problem with doubleGeneDeletion status output

15 views
Skip to first unread message

Eivind Almaas

unread,
Aug 25, 2018, 12:56:03 PM8/25/18
to COBRA Toolbox
Hi,

I’ve just installed the latest version of the cobra toolbox, and when testing the doubleGeneDeletion function, I noticed that the status output is messed up. 

This is caused by two conflicting output statements (lines 116-120 in the function code).  

I suggest that a quick and logical fix will be to select between the two based on verbFlag — or just uncomment one of them.  With the often large number of double-knockouts performed, I think it would be best to forgo the statement in lines 116-118, as this takes many minutes to give feedback for a reasonably-sized model.

Kind regards,
Eivind


Laurent Heirendt

unread,
Aug 27, 2018, 3:25:01 AM8/27/18
to COBRA Toolbox
Dear Eivind,

Thanks for reporting this. I submitted a PR: https://github.com/opencobra/cobratoolbox/pull/1317

Please let me know if these changes are what you were thinking of: https://github.com/opencobra/cobratoolbox/pull/1317/commits/38c95decf79a84dc382b6832e2c82f34453535f1

Best regards,

Laurent
Reply all
Reply to author
Forward
0 new messages