Submission

92 views
Skip to first unread message

katie

unread,
Sep 23, 2020, 12:54:17 PM9/23/20
to cmpt-295-sfu
SFU ID: ksa138
Github username: katiesun138
Line and file:  n/a
Question: For the submission of this assignment, do we just follow the code provided in the "Grading" section of the assignment? Will that push our code onto Travis for marking?

Thank you,
Katie

b.minh96

unread,
Sep 23, 2020, 1:29:25 PM9/23/20
to cmpt-295-sfu
No. That's not enough, that's only for your checking. 
Your code is still in your local machine. So we don't have access to your code even if you passed all the tests cases.
In order to avoid grade of 0 because of that, you need to git push your local changes to remote so that we can run them and check on Travis. 
If you're not so familiar with Git. Knowing these 3 main command will suffice (review lab 0):
git add <file_name>
git commit -m "Commit messages"
git push origin (this pushes changes)

You then check your repo and then will see that it's updated accordingly.
Next, if you open travis you will see your repo being tested by the system.

katie

unread,
Sep 23, 2020, 3:29:27 PM9/23/20
to cmpt-295-sfu
Thanks for the information! As a follow-up question, my local tests all passed but in Travis it failed. When I used valgrind to check I have memory that is "definitely lost", but it occurs in the arraylist_new function.

Does Travis fail because there is memory that is definitely lost or is something in my code incorrect?
How should I approach fixing this problem?

Thanks!
Katie

Arrvindh Shriraman

unread,
Sep 23, 2020, 4:41:57 PM9/23/20
to cmpt-295-sfu
Code is incorrect.

b.minh96

unread,
Sep 23, 2020, 4:47:56 PM9/23/20
to cmpt-295-sfu
Looking in more details at your code. Part 2 binary tree is not implemented. 
You need to finished all the questions so that travis can show pass.

Reply all
Reply to author
Forward
0 new messages