Groups keyboard shortcuts have been updated
Dismiss
See shortcuts

Contributing to cmockery via github.

98 views
Skip to first unread message

Shauna Thomas

unread,
Aug 4, 2012, 6:18:53 AM8/4/12
to cmoc...@googlegroups.com
Hello,

I have been working with CFEngine to expand our unit testing framework. We have added functionality for print testing results from cmockery to xml format. Now I would like to make this available to the cmockery community. Is there an official cmockery account on github where I can fork and then submit a pull request, to contribute to the project? Thank you!

Best,
Shauna Thomas

Andreas Schneider

unread,
Aug 4, 2012, 8:16:40 AM8/4/12
to cmoc...@googlegroups.com
On Saturday 04 August 2012 03:18:53 Shauna Thomas wrote:
> Hello,

Hey,
this community looks pretty dead. I've tried to contact the devs here on the
mailing list and friends at Google. Nobody really responded to I forked the
project.

Website:

https://open.cryptomilk.org/projects/cmocka

Git repositories:
http://git.cryptomilk.org/projects/cmocka.git/

I've migrated it to the cmake build system. You can create a windows installer
if you call the package target.

It has a quite some bugfixes. Patches are welcome, just send them to the
mailiglist.

I'm also fine to close my project and merge everything back into cmockery.


Cheers,


-- andreas


--
Andreas Schneider GPG-ID: F33E3FC6
www.cryptomilk.org a...@cryptomilk.org

Stewart Miles

unread,
Aug 4, 2012, 9:38:26 AM8/4/12
to cmoc...@googlegroups.com

The project isn't really dead we're just very busy - as always. We're still actively using it internally and would love additional contributors. On googlecode join the group as a contributor setup a branch and we can start reviewing / merging into trunk whenever your changes are available.

--
You received this message because you are subscribed to the Google Groups "Cmockery" group.
To post to this group, send email to cmoc...@googlegroups.com.
To unsubscribe from this group, send email to cmockery+u...@googlegroups.com.
For more options, visit this group at http://groups.google.com/group/cmockery?hl=en.

Shauna Thomas

unread,
Aug 5, 2012, 11:13:14 AM8/5/12
to cmoc...@googlegroups.com
Hi Stewart,

I do not see an option where I can add myself as a contributor. But I will be happy to contribute our updates, if you or another owner of the cmockery group will add me to the group. Thanks!

Shauna
To unsubscribe from this group, send email to cmockery+unsubscribe@googlegroups.com.

Stewart Miles

unread,
Aug 5, 2012, 11:44:15 AM8/5/12
to cmoc...@googlegroups.com

I've added you as a contributor. Create a branch apply your changes / send them for review and we'll try getting them into trunk.

Btw: How do folks feel about switching the repo to git?

To view this discussion on the web visit https://groups.google.com/d/msg/cmockery/-/0jI2wdlLFigJ.

To post to this group, send email to cmoc...@googlegroups.com.
To unsubscribe from this group, send email to cmockery+u...@googlegroups.com.

Shauna Thomas

unread,
Aug 5, 2012, 12:41:50 PM8/5/12
to cmoc...@googlegroups.com
Thanks, Stewart! I'll set up a branch and start submitting our changes... I think switching to git sounds like an excellent idea :)

Stewart Miles

unread,
Aug 5, 2012, 12:58:09 PM8/5/12
to cmoc...@googlegroups.com

OK I've switched the repo to git.

To view this discussion on the web visit https://groups.google.com/d/msg/cmockery/-/OiwFkwo3RBgJ.

To post to this group, send email to cmoc...@googlegroups.com.
To unsubscribe from this group, send email to cmockery+u...@googlegroups.com.

Shauna Thomas

unread,
Aug 6, 2012, 4:15:17 AM8/6/12
to cmoc...@googlegroups.com
Excellent... I have both svn and git repositories, however the git
repository appears to still be empty. I'll just copy the data from svn
to git for now, and fork a branch from there.
>>>>>> cmockery+u...@googlegroups.com.
>>>>>> For more options, visit this group at
>>>>>> http://groups.google.com/group/cmockery?hl=en.
>>>>>>
>>>> --
>>>> You received this message because you are subscribed to the Google
>>>> Groups "Cmockery" group.
>>>> To view this discussion on the web visit
>>>> https://groups.google.com/d/msg/cmockery/-/0jI2wdlLFigJ.
>>>> To post to this group, send email to cmoc...@googlegroups.com.
>>>> To unsubscribe from this group, send email to
>>>> cmockery+u...@googlegroups.com.
>>>> For more options, visit this group at
>>>> http://groups.google.com/group/cmockery?hl=en.
>>
>> --
>> You received this message because you are subscribed to the Google Groups
>> "Cmockery" group.
>> To view this discussion on the web visit
>> https://groups.google.com/d/msg/cmockery/-/OiwFkwo3RBgJ.
>> To post to this group, send email to cmoc...@googlegroups.com.
>> To unsubscribe from this group, send email to
>> cmockery+u...@googlegroups.com.
>> For more options, visit this group at
>> http://groups.google.com/group/cmockery?hl=en.
>
> --
> You received this message because you are subscribed to the Google Groups
> "Cmockery" group.
> To post to this group, send email to cmoc...@googlegroups.com.
> To unsubscribe from this group, send email to

Shauna Thomas

unread,
Aug 8, 2012, 7:33:55 AM8/8/12
to cmoc...@googlegroups.com
Hi Stewart,

I've set up our changes in my own branch. But I'm having difficulty putting in a pull request to the cmockery git repository. Can you please help me to submit a request? Thanks!

Shauna
To unsubscribe from this group, send email to cmockery+u...@googlegroups.com.
For more options, visit this group at http://groups.google.com/group/cmockery?hl=en.

--
You received this message because you are subscribed to the Google Groups "Cmockery" group.
To view this discussion on the web visit https://groups.google.com/d/msg/cmockery/-/0jI2wdlLFigJ.
To post to this group, send email to cmoc...@googlegroups.com.
To unsubscribe from this group, send email to cmockery+u...@googlegroups.com.
For more options, visit this group at http://groups.google.com/group/cmockery?hl=en.

Stewart Miles

unread,
Aug 8, 2012, 12:56:39 PM8/8/12
to cmoc...@googlegroups.com
Before I changed the repo I should have probably taken a look to see
what exactly that means. I didn't do what I expect and migrate the
svn repo to git, instead it just initialized an empty git repo. The
old svn repo is still there it's just hidden - great - so what I'll do
is migrate to the git repo today and then figure out how the mechanics
of this will work with git on googlecode.

Generally this is the way the code review system works on googlecode.
http://code.google.com/p/support/wiki/CodeReviews
> https://groups.google.com/d/msg/cmockery/-/LVxxRoHWwwEJ.

Stewart Miles

unread,
Aug 8, 2012, 1:55:28 PM8/8/12
to cmoc...@googlegroups.com
Ok, I've imported everything from the old svn repo into a new git
repo. Each release is broken out into a separate branch.

I suggest creating a remote branch for your changes based upon master.
http://code.google.com/p/cmockery/source/createClone once you're
changes are in you can submit patches for code review by e-mailing
cmoc...@googlegroups.com with a reference to the patch URL e.g
http://code.google.com/r/stewartamiles-reviewtest/source/detail?r=2129f67a5158acedb3e434d732915a90846e17c4
. Reviewers can review the code using the "Start code review" link on
the top right of the page. Once the patch set looks good you can send
a pull request to this list and I'll merge into cmockery/master.

Sound ok?

Shauna Thomas

unread,
Aug 9, 2012, 2:50:41 AM8/9/12
to cmoc...@googlegroups.com
Sounds good, I'll give it a try :)

Andreas Schneider

unread,
Aug 11, 2012, 5:13:23 AM8/11/12
to cmoc...@googlegroups.com
On Wednesday 08 August 2012 10:55:28 Stewart Miles wrote:
> Ok, I've imported everything from the old svn repo into a new git
> repo. Each release is broken out into a separate branch.
>
> I suggest creating a remote branch for your changes based upon master.
> http://code.google.com/p/cmockery/source/createClone once you're
> changes are in you can submit patches for code review by e-mailing
> cmoc...@googlegroups.com with a reference to the patch URL e.g
> http://code.google.com/r/stewartamiles-reviewtest/source/detail?r=2129f67a51
> 58acedb3e434d732915a90846e17c4 . Reviewers can review the code using the
> "Start code review" link on the top right of the page. Once the patch set
> looks good you can send a pull request to this list and I'll merge into
> cmockery/master.
>
> Sound ok?

Hi,

why don't you just take a look at my git repo and use it as the starting base
for the git repo.

It has:

a) a lot of patches applied from your bugtracker
b) a new build system (you can build on all unix systems and windows; yes
Visual Studio works just fine
c) a lot of fixes I did


http://git.cryptomilk.org/projects/cmocka.git/log/

Shauna Thomas

unread,
Aug 11, 2012, 8:24:30 AM8/11/12
to cmoc...@googlegroups.com
Stewart,

I have my repository set up in googlecode. The interface actually
seems very nice so far :) so now I am going to try submitting a patch
for review...

On Wed, Aug 8, 2012 at 7:55 PM, Stewart Miles <stewar...@gmail.com> wrote:

Stewart Miles

unread,
Aug 11, 2012, 11:57:36 AM8/11/12
to cmoc...@googlegroups.com
Andreas would it be possible to clone the repo on googlecode and apply
your changes on top of it? That would give others the opportunity to
review and test the changes before merging them into trunk.
Reply all
Reply to author
Forward
0 new messages