Plone conference

1 view
Skip to first unread message

Michael Davis

unread,
Sep 30, 2008, 4:37:09 PM9/30/08
to cmfque...@googlegroups.com
Hi,

Is anyone going to the Plone conference this year?

It might be good to do a sprint on PloneSurvey to get it fully compatible
with Plone 3.0. I've not had enough time to make a final 2.5 release with
all the things I planned, but the code should be cleaner, making the
transition to 3 easier. We can tag the trunk to park 2.5 compatibility in
case anyone still needs it (which would include me)

If anyone is interested, can they let me know before Friday, so I can
register the sprint before I fly out.

Cheers
Michael

Yuri

unread,
Oct 1, 2008, 2:52:56 AM10/1/08
to PloneSurvey
Have a good travel :)

BTW, I'm taking today and tomorrow to try to implement Survey Matrix
with a text field instead of a radio button.

Some advice before I start? :)

Michael Davis ha scritto:

Davis, Michael

unread,
Oct 1, 2008, 5:00:15 AM10/1/08
to cmfque...@googlegroups.com
Hi Yuri,

I would suggest a different approach. I'm assuming you want a table bank
of text questions. So it's more of a layout issue. Perhaps a new
folderish question, which can contain multiple text questions.

Trying to use the matrix question this way would lead to problems with
validation and other issues, I think.

Cheers
Michael

Yuri

unread,
Oct 2, 2008, 3:25:35 AM10/2/08
to PloneSurvey
well, I've done it :)

there's no major issue with the validation (until you use number as
matrix question name), I've also added navigation to subsurvey, so
people can go forward/back :P

Basically I've added a "text" option to SELECT_INPUT_TYPE in config.py
and modified the template (basically copying <input type="checkbox"
and changing it to <input type="text" ).

Also I've fixed a bug in the template where select didn't worked in a
matrix question (basically removed the repeat/option/number cause
there's no option loop:) )

If you've time to sprint in Washington DC to port PS to plone3 send us
a mail :)

Davis, Michael

unread,
Oct 2, 2008, 5:24:58 AM10/2/08
to cmfque...@googlegroups.com
Hi Yuri,

Cool. I was thinking more of flexibility, I think. I can see someone wanting to alter the layout of a text bank of questions, but not affect a vocab matrix.

Have you checked these in, I'm not seeing them. You will probably get a conflict, as I checked in the fix for the option loop being called in the id attribute.

It doesn't look like there will be anyone to sprint with, but will see when I get there. Will probably get some done in transit, hopefully get the cookies issues sorted. This might have an impact on your navigation for forward/back, so would be good if you could check that into trunk.

Yuri

unread,
Oct 2, 2008, 6:53:07 AM10/2/08
to PloneSurvey
I've also fixed the save button in validate_survey.py:


# value = form.get(matrix_q.getId(), '')
matrix_qid = str(q.getId()) + '-' +
str(matrix_q.getId())
value = form.get(matrix_qid, '')
matrix_q.addAnswer(value)
return state.set(status='success')

the id has changed cause we could had items with the same id (an error
we found and you've fixed) but it was not fixed for the "save" case.

I've found a lot of duplicate code :P

Yuri

unread,
Oct 3, 2008, 3:51:34 AM10/3/08
to PloneSurvey


On 2 Ott, 11:24, "Davis, Michael" <m.r.da...@cranfield.ac.uk> wrote:
> Hi Yuri,
>
> Cool. I was thinking more of flexibility, I think. I can see someone wanting to alter the layout of a text bank of questions, but not affect a vocab matrix.
>
> Have you checked these in, I'm not seeing them.

I don't have submitted them, cause I've to do more "tuning" :)

> You will probably get a conflict, as I checked in the fix for the option loop being called in the id attribute.

Good, have looked also to the "save" button? I think the code should
be the same for save and submit, other than going to next page.

>
> It doesn't look like there will be anyone to sprint with, but will see when I get there. Will probably get some done in transit, hopefully get the cookies issues sorted. >This might have an impact on your navigation for forward/back, so would be good if you could check that into trunk.

I direct link the subsurveys, I don't have back forward because it is
difficult to know where I came from, without adding more data.

Davis, Michael

unread,
Oct 3, 2008, 5:36:39 AM10/3/08
to cmfque...@googlegroups.com

Hi Yuri,

Look forward to you checking them in.

The save facility has always been flaky, as there was no easy way to naviage
a partially filled in survey, so wasn't a priority. I agree that save should
exit the survey, with a reminder for them to come back later.

The getNextPage method should return the next relevant page, so you could
use that for the next button, a similar getPreviousPage could use the same
logic in reverse to get the previous relevant page. Not sure about the
portlet yet, as there is an issue with future pages with branch conditions
which may not be relevant. Perhaps greying out pages with branch conditions
until the condition has been met.

Cheers
Michael

Reply all
Reply to author
Forward
0 new messages