Pull from hg.icculus.org ...

1 view
Skip to first unread message

Ryan C. Gordon

unread,
Mar 17, 2008, 9:19:25 PM3/17/08
to CMakeLua

Fixed (err...avoid) crash in Cygwin during bootstrapp cmake's initial
run...

http://hg.icculus.org/icculus/CMakeLua/rev/b5ab2f616c71

(it's not a CMakeLua bug, fwiw.)


Corrected CMakeLists.txt for systems without extra Lua CFLAGS (like
Windows)...

http://hg.icculus.org/icculus/CMakeLua/rev/e247df098535


Cleaned up Lua header inclusion...previously, we were using the system-
installed headers, and failing to bootstrap if they weren't there!

http://hg.icculus.org/icculus/CMakeLua/rev/d4a1bcb35dff



This got me running on Windows, with both Cygwin and MSYS. Building
CMake by generating Visual Studio 8 project files for it fails to
link, but this appears to be true in cmake.org's CVS, too. Using
CMakeLua to build Toby (http://icculus.org/toby/), a Windows GUI
application, worked fine, though.


These are all CMake scripts, though...do we have any meaningful
CMakeLists.lua files, or are we still just rolling Hello World test
cases?

--ryan.

E. Wing

unread,
Mar 18, 2008, 2:39:41 PM3/18/08
to cmak...@googlegroups.com
> This got me running on Windows, with both Cygwin and MSYS. Building
> CMake by generating Visual Studio 8 project files for it fails to
> link, but this appears to be true in cmake.org's CVS, too. Using
> CMakeLua to build Toby (http://icculus.org/toby/), a Windows GUI
> application, worked fine, though.

Thanks for the changes. I'm backlogged here, so I just checked them in
and didn't bother testing/verifying anything. (You sure you don't want
repo write access?)

> These are all CMake scripts, though...do we have any meaningful
> CMakeLists.lua files, or are we still just rolling Hello World test
> cases?

No, we still don't have any meaningful CMakeLists.lua files. This
needs to be done. We need both unit test like things for testing
individual things like API testing, fancy argument handing, variable
bridging (one direction, both directions), variable scoping, etc. And
we need some real-world-like projects to pound on things. Though I
should warn you that we haven't finalized the scripting interface
design so having too many projects at this point may cause different
problems.

Thanks,
Eric

Ken Martin

unread,
Mar 18, 2008, 3:42:03 PM3/18/08
to cmak...@googlegroups.com
> No, we still don't have any meaningful CMakeLists.lua files. This
> needs to be done. We need both unit test like things for testing
> individual things like API testing, fancy argument handing, variable
> bridging (one direction, both directions), variable scoping, etc. And
> we need some real-world-like projects to pound on things. Though I
> should warn you that we haven't finalized the scripting interface
> design so having too many projects at this point may cause different
> problems.


The tests in CMake/Tests cover a lot of different issues in CMake and they
come in mostly bite sized pieces. Plus converting them has the advantage
that they can become your Lua regression test suite.

Ken


Reply all
Reply to author
Forward
0 new messages