Running plug-in on JDK6

21 views
Skip to first unread message

roland...@gmail.com

unread,
Feb 7, 2014, 9:24:39 AM2/7/14
to cmake-maven-...@googlegroups.com
Hi everyone,

I just found this plug-in and want to try it out to see if it can help replace our current build-environment with Maven. The problem I have is that we are using JDK6 and your code is relying pretty heavily on JDK7. Is there a possibility for a JDK6 release? Or is there perhaps a certain point in history that was still compatible with JDK6 which I can use?

The problem for me is that it is not possible (right now) to update to JDK7...

Thanks.

Roland

Kevin S. Clarke

unread,
Feb 7, 2014, 9:53:31 AM2/7/14
to cmake-maven-...@googlegroups.com
Looking at creating a different branch that would be JDK6 compatible
is on my list of todos (after improving the ctest support in the main
branch). I don't have an immediate timeframe for it, though; as you
note, the current code relies pretty heavily on JDK7 features.

Kevin
> --
> You received this message because you are subscribed to the Google Groups
> "cmake-maven-project-users" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to cmake-maven-projec...@googlegroups.com.
> For more options, visit https://groups.google.com/groups/opt_out.



--
"There are two kinds of people in this world: those who believe there
are two kinds of people in this world and those who know better."

roland...@gmail.com

unread,
Feb 8, 2014, 5:35:18 AM2/8/14
to cmake-maven-...@googlegroups.com
OK, thanks. Well, I can perhaps test on a JDK7 to see if I can get our builds to run and when I'm satisfied with the results and have convinced my PL, we'll see how far along you are... :-)
Or maybe in my spare time I will check out your code-base and see if I can lend a hand. I assume that's OK with you?

Roland



On Friday, February 7, 2014 3:53:31 PM UTC+1, Kevin S. Clarke wrote:
Looking at creating a different branch that would be JDK6 compatible
is on my list of todos (after improving the ctest support in the main
branch).  I don't have an immediate timeframe for it, though; as you
note, the current code relies pretty heavily on JDK7 features.

Kevin


On Fri, Feb 7, 2014 at 9:24 AM,  <roland...@gmail.com> wrote:
> Hi everyone,
>
> I just found this plug-in and want to try it out to see if it can help
> replace our current build-environment with Maven. The problem I have is that
> we are using JDK6 and your code is relying pretty heavily on JDK7. Is there
> a possibility for a JDK6 release? Or is there perhaps a certain point in
> history that was still compatible with JDK6 which I can use?
>
> The problem for me is that it is not possible (right now) to update to
> JDK7...
>
> Thanks.
>
> Roland
>
> --
> You received this message because you are subscribed to the Google Groups
> "cmake-maven-project-users" group.
> To unsubscribe from this group and stop receiving emails from it, send an

Kevin S. Clarke

unread,
Feb 8, 2014, 4:41:32 PM2/8/14
to cmake-maven-...@googlegroups.com
On Sat, Feb 8, 2014 at 5:35 AM, <roland...@gmail.com> wrote:

> Or maybe in my spare time I will check out your code-base and see if I can
> lend a hand. I assume that's OK with you?

I'm definitely willing to look at patches (especially those with
tests), but the project isn't really mine. I'm just a helper, so it
would really be up to the project owner.

Kevin

roland...@gmail.com

unread,
Feb 19, 2014, 12:59:42 PM2/19/14
to cmake-maven-...@googlegroups.com
From what I saw, I only need the 'cmake-maven-plugin' to run on JDK6, the other 2 projects can remain on JDK7...

So, here is a patch. No new tests included, I think it is enough that the old tests still run... I mean, it compiles with JDK6 (which is proof that it works) and the tests also run on JDK6...
Btw, you can build and release the whole thing (all 3 projects) with JDK7 if you want, the resulting JAR is JDK6 compatible! -- This can't be tested with an included test, since you would need to switch JDKs somehow... (although, tool-chain might work, but unfortunately I never checked that out).

Would love for you to include this in (one of) the next release(s), but at least for now I can use my local snapshot for further testing!

Roland
jdk6.patch

Kevin S. Clarke

unread,
Feb 19, 2014, 3:22:13 PM2/19/14
to cmake-maven-...@googlegroups.com
Thanks Roland! I'll take a look at this tonight.

Kevin
> --
> You received this message because you are subscribed to the Google Groups
> "cmake-maven-project-users" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to cmake-maven-projec...@googlegroups.com.

Kevin S. Clarke

unread,
Feb 20, 2014, 1:00:51 AM2/20/14
to cmake-maven-...@googlegroups.com
Thanks Roland. I've integrated your patch. It will be in the next release.

Kevin

roland...@gmail.com

unread,
Feb 20, 2014, 5:17:04 AM2/20/14
to cmake-maven-...@googlegroups.com
Thanks Kevin!
I will keep testing with my Snapshot until the next release is done. Looks like this plug-in is doing exactly what I need!

Roland
Reply all
Reply to author
Forward
0 new messages