maser dr label

[Marios Chatzikos]

Hello,

The attached patch changes the string written in the 'save dr' output from:
    H maser dTauMase=-2.00e-01 -10 7 3 0
to
    OH maser, levels 3 0, dTauMase=-2.00e-01
which is much more useful, as you don't have to look up which species
index 7 points to.

RT_line_one_tauinc was called with various negative numbers to indicate
different sets of spectral lines (-10 above for database lines).  Some
of these are instead suitably annotated, see patch.

I'd also like to delete the comment in radius_next.cpp, lines 175-180 below:

 169         if( rt.dTauMase < -0.01 )
 170         {
 171                 /* maser so powerful, must limit inc in tau
 172                  * >>chng 96 aug 08, from 0.3 to 0.1 due to large
maser crash */
 173                 double drHMase =
radius.drad*MAX2(0.1,-0.2/rt.dTauMase);
 174                 ostringstream oss;
 175                 //
 176                 // NB NB -- DON'T ALTER THIS STRING, setting
rt.lgMaserSetDR below keys from this!
 177                 // No longer true:
 178                 // >>chng 13 oct 01 rjrw take logical pointer
argument for
 179                 // >>optional flag to be set if selected
 180                 //
 181                 oss << rt.mas_species << " maser, levels " <<
rt.mas_hi << " " << rt.mas_lo;
 182                 oss << ", dTauMase=" << scientific <<
setprecision(2) << rt.dTauMase << " ";
 183                 drChoice.insert( drHMase, oss.str(),
&rt.lgMaserSetDR );
 184         }

which may had been useful when first written, but is just confusing now.

Let me know if you have any suggestions for improvement, or any other
comments.

Thanks,

Marios

[Marios Chatzikos]

Hi again,

I've talked to Gary, and he agreed the patch looks OK to commit. We did
not discuss about removing the comment.  Would there be any objections
to that?

To recap: Lines 175-180 below are essentially the fossil record of that
bit of code -- they don't add any value to its current state, and indeed
I found them to be confusing.

Thanks,

Marios

[Marios Chatzikos]

The comment in radius_next.cpp has been removed.  The level indices of
database lines have been incremented to refer to the levels in the
original data files.  See HEAD of masers branch.

Let me know if you have any comments.

Thanks,

Marios

[Robin Williams]

Hi Marios --

Removing the comment is fine by me -- it was providing background for why I'd done what the pre-existing comment had said not to do, but that's all water long under the bridge now.

Best wishes

  Robin

--
--
http://groups.google.com/group/cloudy-dev
---
You received this message because you are subscribed to the Google Groups "cloudy-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email to cloudy-dev+...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/cloudy-dev/3f4e4289-5752-bf0f-0fd0-6e1916a5e598%40gmail.com.