Re: troposphere/apigateway changes

22 views
Skip to first unread message

Mark Peek

unread,
Jul 30, 2024, 12:31:16 PM7/30/24
to Billy McLean, cloudtools-dev
Billy,
Likely you cloned troposphere using the https endpoint and you can't
push changes. The workflow you should use is:
- Fork troposphere into your own set of repositories
- Clone that repo down to your system using the ssh method
- Create a feature branch for your changes and commit the changes
- Push that branch back to your forked repo
- Do a Pull Request (PR) which will open a PR from your repo to the
troposphere repo

Having said this, if it is a trivial change you could always open an
Issue with a patch and I could see about committing it directly.

Mark

On Tue, Jul 30, 2024 at 9:16 AM Billy McLean <billy....@protagona.com> wrote:
>
> Hello.
>
> I have created a new branch, and am attempting to change the 'validate_timeout_in_millis functions in apigatewa.py and apigatewayv2.py, to increase the maximum value of the int from 29,000 to 900,000. This is due to the recent update that allows the integration timeout time to be increased beyond 29,000: https://aws.amazon.com/about-aws/whats-new/2024/06/amazon-api-gateway-integration-timeout-limit-29-seconds/
>
> When I attempt to push this branch up, I am met with a 403 error. I'm sorry, this is probably a very stupid question, but I haven't contributed to an opensource repo like this before. How do I correct this? Is there somewhere I can request access?
>
> --
> You received this message because you are subscribed to the Google Groups "cloudtools-dev" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to cloudtools-de...@googlegroups.com.
> To view this discussion on the web visit https://groups.google.com/d/msgid/cloudtools-dev/e61f2646-aece-4e28-a91b-347c675f374en%40googlegroups.com.

Mark Peek

unread,
Jul 30, 2024, 12:44:38 PM7/30/24
to Billy McLean, cloudtools-dev
Also, I just looked at the AWS doc link you sent and I didn't see the
900,000 number. Can you point me to the new maximum documented by AWS?

Thanks,
Mark
Reply all
Reply to author
Forward
Message has been deleted
Message has been deleted
0 new messages