Serverless module fixes

13 views
Skip to first unread message

Vladimir Mohammad (InQuirer)

unread,
Apr 19, 2024, 4:29:46 AM4/19/24
to cloudtools-dev
Hello,

I'm new here. Recently I've found two inconsistencies with the latest docs (didn't fix all the rest):
add FilterCriteria to serverless/KinesisEvent
currently, the test step `Ensure spec generation and formatting fixups are clean` fails
I assume it would be fixed by merging Updates from spec version 169.0.0 #2233

please, let me know if I did something wrong.

Mark Peek

unread,
Apr 22, 2024, 3:22:39 PM4/22/24
to Vladimir Mohammad (InQuirer), cloudtools-dev
Vladimir,
Thank you for the PRs and I will see about reviewing/merging today/tomorrow.

You are correct, PRs will fail that step if there are pending spec changes that are not committed yet.
I really need to record the base spec version used in a release so PRs can be done against a known stable version.

Mark

--
You received this message because you are subscribed to the Google Groups "cloudtools-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email to cloudtools-de...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/cloudtools-dev/0bf749d8-a420-4954-b946-3932961bcb36n%40googlegroups.com.
Reply all
Reply to author
Forward
0 new messages