Help with new spec to update RDS validator logic

[Trent Nielsen]

Hello,

Recently, I submitted a PR to address RDS validator logic issues, and took a crack at updating the refspec updates in order to get CI to pass. I ran into some issues and was hoping for some guidance for further changes or review. 

Pylint not passing - During refspec regen, some refspec objects end up out of order in the connect module. It appears that some classes have circular type dependencies, specifically with the `EvaluationForm` resources. 

To work around this issue, I took the liberty of applying patch changes to remove or replace object type. In addition to the refspec having these circular class dependencies, there is a recursion issue when scanning. I was able to duplicate this fix by adding a line to gen.py to avoid this issue in the way the wafv2 module does. 

Does it appear that I am doing this right?  I would like to be able to contribute in a way that helps keep the project going, in any way possible. 

Thanks!

https://github.com/cloudtools/troposphere/pull/2164

-Trent

[Mark Peek]

Trent,

Thank you for the PR. I've been extremely busy with my day job but will find some time to take a look at the PR and the errors you've encountered.

Thanks,

Mark

--
You received this message because you are subscribed to the Google Groups "cloudtools-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email to cloudtools-de...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/cloudtools-dev/496645ad-b533-4687-a6bb-4d0ac4800ab6n%40googlegroups.com.