Contributing without generating new spec

[Trent Nielsen]

Hi team,

I am a user of Troposphere and an occasional contributor to the code base. As a result, I have the ability of CI to execute as I am not a "first time user". 

I have a few questions regarding pull requests.

- For a simple validator change, where the modules are not changing, does the PR have to be updated to the latest CF spec? To ask it differently, does CloudTools require CI to pass for all PRs or only where spec is updated?

- Post-reinvent, there are many updates, and the latest automated PR in the pipe for the spec is version 101. When submitting a PR for a small change recently, there are quite a few new additions, with the latest spec version on 108. Does CI stop on the first error, or does it run through the entire list of services? I began evaluating the work to make CI pass, and I was unsure if the first error (auditmanager discrepancies) stopped CI, or if I would be going through every single template to get it to pass.
- How often does CloudTools see themselves updating CF spec? Is there a quarterly review/release schedule or is it best effort?  Is CloudTools heavily reliant on community contributions in order to drive the updates of CF spec updates?

Thanks in advance, I love the library, and love your work, just having clarification around release schedules and PRs would be super helpful for setting expectations within my org for our tooling.

-Trent

[Mark Peek]

Trent,

Thank you for the questions.

 

- For a simple validator change, where the modules are not changing, does the PR have to be updated to the latest CF spec? To ask it differently, does CloudTools require CI to pass for all PRs or only where spec is updated?

Right now the PRs need to pass whatever the *latest* spec is rather than the latest one incorporated into troposphere. This does cause issues when there is spec breakage that I'd like to fix in the future.

 

- Post-reinvent, there are many updates, and the latest automated PR in the pipe for the spec is version 101. When submitting a PR for a small change recently, there are quite a few new additions, with the latest spec version on 108. Does CI stop on the first error, or does it run through the entire list of services? I began evaluating the work to make CI pass, and I was unsure if the first error (auditmanager discrepancies) stopped CI, or if I would be going through every single template to get it to pass.

The automation stops upon any error. Perhaps this can be relaxed a bit to allow for a partial set of services to be emitted. The 101 spec changes was a bit big which delayed me reviewing and then there was further breakage in 102 that I never got around to resolving. I will look to rectify the backlog and get a new release out (likely aligning with any new changes coming out this week).

 

- How often does CloudTools see themselves updating CF spec? Is there a quarterly review/release schedule or is it best effort?  Is CloudTools heavily reliant on community contributions in order to drive the updates of CF spec updates?

AWS releases new specs (usually) every week Thu/Fri-ish. The troposphere tooling runs daily in the mornings to pick up the change. If nothing breaks, it is an easy merge. Otherwise it takes time to diagnose. The main contributions from the community would be improving the validators and possibly helping to fix a broken spec with a patch. But the main code for the resources is automated driven off the AWS spec at this point.

Mark

--
You received this message because you are subscribed to the Google Groups "cloudtools-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email to cloudtools-de...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/cloudtools-dev/48095685-c783-4dd8-9863-0c694f5e1ca3n%40googlegroups.com.