Code review requests for a few proposed patches

[Andrew Mattie]

I have a few outstanding requests for code reviews. Can I get a reviewer on these please?

Make UI sliders work with touch* events

http://code.google.com/p/closure-library/issues/detail?id=245

goog.userAgent.product.isVersion broken for Android

http://code.google.com/p/closure-library/issues/detail?id=279

Dragger often doesn't work for touch* events

http://code.google.com/p/closure-library/issues/detail?id=382

goog.History.HAS_ONHASHCHANGE should use feature detection instead of UA sniffing

http://code.google.com/p/closure-library/issues/detail?id=417

Andrew Mattie

[Bjorn Tipling]

Interesting. Good luck!

On Feb 6, 1:52 pm, Andrew Mattie <amat...@gmail.com> wrote:
> I have a few outstanding requests for code reviews. Can I get a reviewer on
> these please?
>
> Make UI sliders work with touch* eventshttp://code.google.com/p/closure-library/issues/detail?id=245
>

> goog.userAgent.product.isVersion broken for Androidhttp://code.google.com/p/closure-library/issues/detail?id=279
>
> Dragger often doesn't work for touch* eventshttp://code.google.com/p/closure-library/issues/detail?id=382

[Nathan Wright]

It'd be great to see these changes applied. Those touch event fixes would really come in handy for the project I'm working on.

Nathan 

[Nathan Naze]

I'll take care of finding reviewers for these.

Nathan

[Carsten Kraus]

Hm, unfortunately there's very poor progress in the code review process.

Why is that? 

From reading through the touch-related review tickets, it seems Andrew is responding very well to suggestions, but his patches wont get ingested whatsoever. 

Neither alternative solutions are being offered. Instead, activity in the review thread just stops for over a month every now and then.

This has to be very frustrating and demotivating for Andrew(and other contributors).

Its 2012 and the otherwise so comprehensive library lacks proper touch support? Really?

If backwards compatibility or performance considerations are the reason for this, I'd like to suggest that we take 'experimental' fixes like Andrews and put them in the goog.labs namespace until committers finally regard them as ready for primetime.

Btw I actually love the introduction of /labs as it brings some fresh air into the sometimes rather conservatively managed lib. 

Lets make more use of it & also use it for easier contributions!