Maven 2 plugin

26 views
Skip to first unread message

Sten Roger

unread,
Dec 21, 2009, 6:06:41 PM12/21/09
to Closure Compiler Discuss
Hi.

I have a simple Maven 2 plugin and Ant task that uses Closure Compiler
+ joins multiple files. Any interest in hosting the code in the
closure-compiler project? If not I will start a project here at google
code to host the Ant task and Maven 2 plugin.

Regards,
Sten Roger Sandvik

Nick Santos

unread,
Dec 22, 2009, 10:46:10 AM12/22/09
to closure-comp...@googlegroups.com

Sounds good to me.

The Issue tracker has a template for code reviews. Could you file a
request and attach a diff? One of the committers will take a look.
http://code.google.com/p/closure-compiler/issues/entry?template=Review%20request

Thanks!
Nick

Martin Palma

unread,
Dec 30, 2009, 4:45:39 PM12/30/09
to closure-comp...@googlegroups.com
Any status update on that?

Bye,
Martin

Sten Roger

unread,
Jan 8, 2010, 3:14:28 PM1/8/10
to Closure Compiler Discuss
Hi.

Been very buissy with other stuff so the Maven plugin was on hold. I
will try to clean up the code a bit and post it for review in the week
to come.

/srs

On 30 Des 2009, 22:45, Martin Palma <mar...@palma.bz> wrote:
> Any status update on that?
>
> Bye,
> Martin
>

> On Tue, Dec 22, 2009 at 4:46 PM, Nick Santos <nicksan...@google.com> wrote:
> > On Mon, Dec 21, 2009 at 6:06 PM, Sten Roger <ste...@gmail.com> wrote:
> >> Hi.
>
> >> I have a simple Maven 2 plugin and Ant task that uses Closure Compiler
> >> + joins multiple files. Any interest in hosting the code in the
> >> closure-compiler project? If not I will start a project here at google
> >> code to host the Ant task and Maven 2 plugin.
>
> >> Regards,
> >> Sten Roger Sandvik
>
> > Sounds good to me.
>
> > The Issue tracker has a template for code reviews. Could you file a
> > request and attach a diff? One of the committers will take a look.

> >http://code.google.com/p/closure-compiler/issues/entry?template=Revie...
>
> > Thanks!
> > Nick

Sten Roger

unread,
Jan 8, 2010, 6:35:31 PM1/8/10
to Closure Compiler Discuss
Well, it seems that I cannot create a review request on that url. I
need to enter a valid branch path, but no valid directories exists
under /branches. Any idea how I do it?

> request and attach a diff? One of the committers will take a look.http://code.google.com/p/closure-compiler/issues/entry?template=Revie...
>
> Thanks!
> Nick

Sten Roger

unread,
Jan 8, 2010, 6:40:41 PM1/8/10
to Closure Compiler Discuss
Submitted a defect instead :-) You shoud be able to see it under the
title "Ant CompileTask patch".

On 22 Des 2009, 16:46, Nick Santos <nicksan...@google.com> wrote:

> request and attach a diff? One of the committers will take a look.http://code.google.com/p/closure-compiler/issues/entry?template=Revie...
>
> Thanks!
> Nick

Nick Santos

unread,
Jan 8, 2010, 7:59:34 PM1/8/10
to closure-comp...@googlegroups.com
On Fri, Jan 8, 2010 at 6:35 PM, Sten Roger <ste...@gmail.com> wrote:
> Well, it seems that I cannot create a review request on that url. I
> need to enter a valid branch path, but no valid directories exists
> under /branches. Any idea how I do it?

Ha. I fixed it up so that you don't need a branch; sorry about that.
I'm still figuring out code.google.com myself.

Nick

Reply all
Reply to author
Forward
0 new messages