Contributing tests

2 views
Skip to first unread message

Richard Newman

unread,
Jun 4, 2009, 12:31:23 PM6/4/09
to Clojure
One of the things that occurred to me at last night's Meetup is that
there seems to be a sizable group of people who are keen on
contributing to Clojure, including basic "drudge" work. It also seems
apparent that having a decent test suite is valuable (if only for the
sake of appearances and adoption), though I tend to agree that it's
not a good use of Rich's time.

While this contribution would indeed be easier with git, I'm
disinclined to wait: I'm personally intending to take a look at the
existing tests in contrib, and if I can figure out the test framework,
I'll crank out a few tests for the core.

If a few people did this, tests will accrue over time.

Perhaps more importantly, if we manage to inculcate the attitude that
questions, bugs, and misunderstandings should be captured as tests,
then the important areas — edge cases and bug fixes — will grow
coverage, all without Rich wasting his time.

Thoughts? Opinions? Advice on the test framework? Would my time be
better spent documenting what I learn about the test framework? Should
I go back to bed and get more sleep? :)

Aaron Cohen

unread,
Jun 4, 2009, 2:05:03 PM6/4/09
to clo...@googlegroups.com

Frantisek Sodomka

unread,
Jun 5, 2009, 3:48:20 AM6/5/09
to Clojure
Hello Richard,
any contributions to test_clojure are very welcome!

As a general rule to contribute, you need to fill-in and mail the CA:
http://clojure.org/contributing

When Rich receives your CA and updates the clojure.org website, you
can start creating issues in clojure-contrib and attaching patches to
it. Example:
http://code.google.com/p/clojure-contrib/issues/detail?id=22

Then somebody can come and check-in your tests. After a while, you
could get your own clojure-contrib check-in rights, but that is solely
Rich's decision.

I am currently writing tests for java_interop, so please don't do any
of those now.
http://code.google.com/p/clojure-contrib/source/browse/trunk/src/clojure/contrib/test_clojure/java_interop.clj

Good way to contribute is also to write regression tests as for
example in vars:
http://code.google.com/p/clojure-contrib/source/browse/trunk/src/clojure/contrib/test_clojure/vars.clj

Files in test_clojure represent different areas - feel free to take
your pick and do whatever you like :-)

Happy testing, Frantisek

Phil Hagelberg

unread,
Jun 5, 2009, 12:16:01 PM6/5/09
to clo...@googlegroups.com
Frantisek Sodomka <fsod...@gmail.com> writes:

> As a general rule to contribute, you need to fill-in and mail the CA:
> http://clojure.org/contributing
>
> When Rich receives your CA and updates the clojure.org website, you
> can start creating issues in clojure-contrib and attaching patches to
> it. Example:
> http://code.google.com/p/clojure-contrib/issues/detail?id=22

A few weeks ago I was talking with OpsCode, a company who works on the
open source Chef project and requires a similar CA. They said they were
working with their lawyers on a way in which contributors could fill out
a form online rather than sending in a signed piece of paper. The
lawyers seemed to think that it was sufficient for the purposes of
copyright assignment, and it would be pretty helpful in simplifying the
contribution process.

If this is something that would be good for Clojure I can contact them
and get more details on what their lawyers recommended. Maybe I could
put together a Compojure app. =)

-Phil

Richard Newman

unread,
Jun 5, 2009, 2:08:10 PM6/5/09
to clo...@googlegroups.com
> As a general rule to contribute, you need to fill-in and mail the CA:
> http://clojure.org/contributing

It's in the mail today.

> Files in test_clojure represent different areas - feel free to take
> your pick and do whatever you like :-)

Great! Looking forward to getting started.

Ray Baquirin

unread,
Jun 5, 2009, 11:39:38 PM6/5/09
to Clojure
or use a digital signature service such as the one reported here:
http://www.techcrunch.com/2009/05/29/make-your-mark-rightsignature-lets-you-sign-documents-online-or-on-your-iphone/

servus,

Ray

On Jun 6, 12:16 am, Phil Hagelberg <p...@hagelb.org> wrote:
Reply all
Reply to author
Forward
0 new messages